From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54958)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WF2bF-0007IK-Tx
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 09:21:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WF2b5-00022J-SB
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 09:21:41 -0500
Received: from mail-qa0-x22e.google.com ([2607:f8b0:400d:c00::22e]:34469)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WF2b5-00022F-OJ
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 09:21:31 -0500
Received: by mail-qa0-f46.google.com with SMTP id k15so7281232qaq.33
	for <qemu-devel@nongnu.org>; Sun, 16 Feb 2014 06:21:31 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5300C968.9040609@redhat.com>
Date: Sun, 16 Feb 2014 15:21:28 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1391179418-13422-1-git-send-email-rth@twiddle.net>
	<1391179418-13422-6-git-send-email-rth@twiddle.net>
In-Reply-To: <1391179418-13422-6-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/5] tcg/i386: Use SHLX/SHRX/SARX
	instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: aurelien@aurel32.net

Il 31/01/2014 15:43, Richard Henderson ha scritto:
> +    gen_shift_maybe_vex:
> +        if (have_bmi2 && !const_args[2]) {
> +            tcg_out_vex_modrm(s, vexop + rexw, args[0], args[2], args[1]);
> +            break;
> +        }
> +        /* FALLTHRU */

What if args[2] happens to be ECX?

Apart from this,

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

so feel free to post PATCH 6/5 and then squash it in the pull request.

Paolo