From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55051)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WF2bw-0007wm-62
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 09:22:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WF2bl-0002Hh-Rz
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 09:22:24 -0500
Received: from mail-qc0-x236.google.com ([2607:f8b0:400d:c01::236]:46852)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WF2bl-0002Hc-MB
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 09:22:13 -0500
Received: by mail-qc0-f182.google.com with SMTP id c9so22306694qcz.41
	for <qemu-devel@nongnu.org>; Sun, 16 Feb 2014 06:22:13 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5300C992.9010903@redhat.com>
Date: Sun, 16 Feb 2014 15:22:10 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1391179418-13422-1-git-send-email-rth@twiddle.net>
	<52FE8E39.3070303@twiddle.net>
In-Reply-To: <52FE8E39.3070303@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/5] tcg/i386 support for bmi
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: aurelien@aurel32.net

Il 14/02/2014 22:44, Richard Henderson ha scritto:
> Ping.
>
> On 01/31/2014 06:43 AM, Richard Henderson wrote:
>> There are three separate architecture extensions for logical operations,
>> BMI, BMI2, and TBM.  The first two are supported on Intel Haswell and
>> AMD Excavator, while slightly earlier AMD support only BMI and TBM.
>>
>> The following adds support for the interesting BMI and BMI2 instructions,
>> where it is easy to do so.  Most of the rest of the new instructions are
>> irrelevant to TCG.
>>
>> When I added support for the ANDC opcode, I noticed some optimization
>> regressions when looking at ppc64 guest dumps.  I will address these
>> in a separate patch set.

Just a small comment on patch 5, everything else looks fine.

Paolo