From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFPdo-0001ve-LC for qemu-devel@nongnu.org; Mon, 17 Feb 2014 09:57:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFPdk-0000bu-5Z for qemu-devel@nongnu.org; Mon, 17 Feb 2014 09:57:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFPdj-0000b4-U2 for qemu-devel@nongnu.org; Mon, 17 Feb 2014 09:57:48 -0500 Message-ID: <53022362.4000809@redhat.com> Date: Mon, 17 Feb 2014 07:57:38 -0700 From: Eric Blake MIME-Version: 1.0 References: <20140216103305.GA28991@redhat.com> In-Reply-To: <20140216103305.GA28991@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VcO2JecmCSR2jfDmxtG1Bqvh9BF6toTrh" Subject: Re: [Qemu-devel] [PATCH] virtio-net: Do not filter VLANs without F_CTRL_VLAN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Stefan Fritsch Cc: Luiz Capitulino , akong@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VcO2JecmCSR2jfDmxtG1Bqvh9BF6toTrh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/16/2014 03:33 AM, Michael S. Tsirkin wrote: > On Wed, Feb 12, 2014 at 10:46:28PM +0100, Stefan Fritsch wrote: >> If VIRTIO_NET_F_CTRL_VLAN is not negotiated, do not filter out all >> VLAN-tagged packets but send them to the guest. >> >> Signed-off-by: Stefan Fritsch >=20 > Thanks for the patch. > I think there are still some issues after this > patch: we need to notify management when > this bit state changes. > And I think libvirt still does not look at the filter info > so it's probably not too late, and cleaner to simply tell it: > "all-vlans". > that is, add > '*vlan': 'RxState', > to the schema. >=20 > (is it true that it needs to be * because old qemu does not produce it?= > maybe not ...) The following conversions are back-compat safe: changing an input parameter from mandatory to optional adding an optional input parameter changing an output parameter from optional to mandatory adding an output parameter (optional or always-present) Regarding whether a parameter must be marked as optional: on input, optional means the user can omit it. On output, marking it as optional means the current version of qemu will sometimes generate it, and sometimes avoid it. If qemu always generates it in the current version, even if it was not generated in an previous version, then an output parameter does not have to be marked optional (that is, behavior of previous qemu versions should not impact the choice of whether the current qemu marks an output as optional - only whether the current qemu sometimes omits the parameter). However, once an output parameter is marked mandatory, you must never remove it in future qemu versions. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VcO2JecmCSR2jfDmxtG1Bqvh9BF6toTrh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTAiNiAAoJEKeha0olJ0Nq8LIH/3PRacbzMaR3Lyldn4Y5QrsK HoHqiL6F360TxrIQ5esccXbhNskaqN8ufKVnoNaH+oK/oi0Mdb9Ib9Mubjt121Zv P1Xnk7k5AmcSsDaM3ESglg2+brRs8X0JGSfjl4deSWE2sdbvkOYQIMGzLo84bWir cv7ded8Fst+cC1XDm5EzNOFHdzv6WbpbSr41Q+nH9JtRLZAAD5S0TryNqPnLSL9k taekZrhAJ6Gflmmu8D/7NanUshn9uSbEbafdUcSAGItmmjx+w4agzhTEGjyVTw3w a1ey8swtqyp313Kqosv3w73sQbtdFm8dy90zVHVUINho/S4/dff0D1Ad4t2pUe8= =cuWG -----END PGP SIGNATURE----- --VcO2JecmCSR2jfDmxtG1Bqvh9BF6toTrh--