From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58748)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WFWzD-00058I-23
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 17:48:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WFWz7-0004fx-3J
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 17:48:26 -0500
Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:45036)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WFWz6-0004fs-TZ
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 17:48:21 -0500
Received: by mail-qc0-f169.google.com with SMTP id w7so24784991qcr.28
	for <qemu-devel@nongnu.org>; Mon, 17 Feb 2014 14:48:20 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <53023917.6060702@twiddle.net>
Date: Mon, 17 Feb 2014 10:30:15 -0600
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1392574872-28725-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1392574872-28725-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/6] A64: finish Neon 3-reg-diff category,
	add LDTR/STTR
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 02/16/2014 12:21 PM, Peter Maydell wrote:
> Another patchset of random filling in the gaps in our Neon
> coverage. Patches 1 through 5 complete our handling of the
> three-reg-different category of Neon instructions.
> 
> Patch 6 implements the "unprivileged load/store" LDTR/STTR
> instructions. (In fact AArch64 Linux doesn't use these, and they're
> pretty pointless in user mode, but they're easy enough to implement.)
> 
> I haven't put in any of the fp_access_check() calls because
> I'm assuming these will pass code review before the system
> emulation patchset does; I'll update the latter to add the
> extra checks as necessary at that point.
> 
> thanks
> -- PMM

Aside from a nit in 5/6,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~