From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49562)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WFRBR-00019H-NC
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 11:36:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WFRBN-0002Cb-56
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 11:36:41 -0500
Message-ID: <53023A7B.8080104@redhat.com>
Date: Mon, 17 Feb 2014 09:36:11 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1392652187-28381-1-git-send-email-imammedo@redhat.com>
	<1392652187-28381-6-git-send-email-imammedo@redhat.com>
In-Reply-To: <1392652187-28381-6-git-send-email-imammedo@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="J4Gdh1OdBFL8Jva5OISdNkFs3A0LwErWe"
Subject: Re: [Qemu-devel] [PATCH 5/6] NUMA: convert -numa option to use
	OptsVisitor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: agraf@suse.de, andre.przywara@amd.com, stefanha@redhat.com, mst@redhat.com, peter.maydell@linaro.org, armbru@redhat.com, ehabkost@redhat.com, lcapitulino@redhat.com, qemu-ppc@nongnu.org, aliguori@amazon.com, pbonzini@redhat.com, afaerber@suse.de, gaowanlong@cn.fujitsu.com, rth@twiddle.net

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--J4Gdh1OdBFL8Jva5OISdNkFs3A0LwErWe
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 02/17/2014 08:49 AM, Igor Mammedov wrote:
> From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>=20
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> +++ b/qapi-schema.json
> @@ -4420,3 +4420,35 @@

> +##
> +# @NumaNodeOptions
> +#
> +# Create a guest NUMA node. (for OptsVisitor)
> +#
> +# @nodeid: #optional NUMA node ID (increase by 1 from 0 if omitted)
> +#
> +# @cpus: #optional VCPUs belong to this node (assign VCPUS round-robin=


s/belong/belonging/

> +#         if omitted)
> +#
> +# @mem: #optional memory size of this node (go halves total memory to
> +#        each node if omitted)

Awkward grammar.  I suggest:

#optional memory size of this node (equally divide total memory among
nodes if omitted)

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--J4Gdh1OdBFL8Jva5OISdNkFs3A0LwErWe
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJTAjp7AAoJEKeha0olJ0NqfoEIAKtZ9cjmdhbg12EDrGIBdOf8
/NtksFw06gpgWlfs2Qwe2iWJmKgFQdOLimSlrwLK2RpJjUEOzyvr5pZfjbcpkfaq
IMWoFnn6TvAFDaklVPb6yUwsZ33PqRREIDvn1ttHX1JdJnq5+RUnpPaXfaBX0XxC
dw2Xjs2KxiQgGOVVcVilUASYsmaNDm1S6lxkhm+1dX61s7xmFvo16rBue/aHvuhc
lXAJvvpdU9fKeIqI+tu7c1ldLZGfFW9YC74ox1/NdnQNIF6RUL20cprPPFNdKWHy
uH40zaWWn/M3grFbLPglyrvU/iXtMc9ORvb3ImR8+BxmYMs+TLdPhhcW4i7xX08=
=yO4B
-----END PGP SIGNATURE-----

--J4Gdh1OdBFL8Jva5OISdNkFs3A0LwErWe--