From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51953)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WFRJP-0006BB-8Q
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 11:45:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WFRJG-0005BX-C9
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 11:44:55 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53023C79.70808@redhat.com>
Date: Mon, 17 Feb 2014 17:44:41 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20140214143408.4b34d2c7@redhat.com>
In-Reply-To: <20140214143408.4b34d2c7@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu-options.hx: improve -numa doc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, ehabkost@redhat.com

Il 14/02/2014 20:34, Luiz Capitulino ha scritto:
> The -numa option documentation in qemu's manpage lacks the command-line
> options and some information regarding how it relates to options -m and
> -smp. This commit fills in the missing text.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  qemu-options.hx | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 56e5fdf..ed1d409 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -97,10 +97,13 @@ ETEXI
>  DEF("numa", HAS_ARG, QEMU_OPTION_numa,
>      "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n", QEMU_ARCH_ALL)
>  STEXI
> -@item -numa @var{opts}
> +@item -numa node[,mem=@var{size}][,cpus=@var{cpu[-cpu]}][,nodeid=@var{node}]
>  @findex -numa
> -Simulate a multi node NUMA system. If mem and cpus are omitted, resources
> -are split equally.
> +Simulate a multi node NUMA system. If @var{mem} and @var{cpus} are omitted,
> +resources are split equally. Also, note that the -@option{numa} option doesn't
> +allocate any of the specified resources. That is, it just assigns existing
> +resources to NUMA nodes. This means that one still has to use the -@option{m}
> +and -@option{smp} options to respectively allocate RAM and vCPUs.
>  ETEXI
>
>  DEF("add-fd", HAS_ARG, QEMU_OPTION_add_fd,
>

Applied to (rebased) NUMA branch.

Paolo