From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFRQj-00023r-9K for qemu-devel@nongnu.org; Mon, 17 Feb 2014 11:52:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFRQe-0007fH-PA for qemu-devel@nongnu.org; Mon, 17 Feb 2014 11:52:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFRQe-0007f2-HI for qemu-devel@nongnu.org; Mon, 17 Feb 2014 11:52:24 -0500 Message-ID: <53023E43.1000706@redhat.com> Date: Mon, 17 Feb 2014 09:52:19 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392604023-20142-1-git-send-email-akong@redhat.com> In-Reply-To: <1392604023-20142-1-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SvhPf9n6O8pjmw05koKHgapEpSHik3FRX" Subject: Re: [Qemu-devel] [PATCH] virtio-net: only output the vlan table when VIRTIO_NET_F_CTRL_VLAN is negotiated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong , qemu-devel@nongnu.org Cc: vyasevic@redhat.com, mst@redhat.com, sf@sfritsch.de, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SvhPf9n6O8pjmw05koKHgapEpSHik3FRX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/16/2014 07:27 PM, Amos Kong wrote: > Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't= > filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiat= ed. >=20 > We should also not send the vlan table to management, this patch makes > the vlan-talbe optional. s/talbe/table/ >=20 > [1] http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg02604.ht= ml >=20 > Signed-off-by: Amos Kong > --- > hw/net/virtio-net.c | 38 +++++++++++++++++++++++++------------- > qapi-schema.json | 4 ++-- > qmp-commands.hx | 2 +- > 3 files changed, 28 insertions(+), 16 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -4034,7 +4034,7 @@ > # > # @main-mac: the main macaddr string > # > -# @vlan-table: a list of active vlan id > +# @vlan-table: #optional a list of active vlan id > # > # @unicast-table: a list of unicast macaddr string > # > @@ -4053,7 +4053,7 @@ > 'multicast-overflow': 'bool', > 'unicast-overflow': 'bool', > 'main-mac': 'str', > - 'vlan-table': ['int'], > + '*vlan-table': ['int'], Indentation is now off. > - "main-mac": main macaddr string (json-string) > -- "vlan-table": a json-array of active vlan id > +- "vlan-table": a json-array of active vlan id (optoinal) s/optoinal/optional/ Those fixes are trivial enough, so I'm okay if you correct them then add:= Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SvhPf9n6O8pjmw05koKHgapEpSHik3FRX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTAj5DAAoJEKeha0olJ0NqZH4IAKFHf14tKB3wQEmtDWyECVF6 0sXyT1rHfukno/Q8IRanUpjR+jOIfiDWnGWwJmfinXcLKhrsMP3Ob4wL6VwTj1Ke JEgoqtlaZF7U7ouJAP6YoKjgZ+AclPJnKm6skMLX3o2IDos/A3ty3GSyeY6RjIvh IP9SZsLYo4JNN4/ZW1RnU2DocKgOLFB4HOjPGUhaw1lA8PgEB5t5Ordf4qHvpH0c YQJI2mtzK4ni5Kv5uvkM0N3g8UMr6A7Z6l4YBx5lqwOiIqVjHsEkmDbUWYZWBMNQ jTBSNHjl2ZGN2fJ+UGHLmeqP5Y5iu+2tXykGugSv48r1RTt7eNzbraV/lWyqvuM= =XvSs -----END PGP SIGNATURE----- --SvhPf9n6O8pjmw05koKHgapEpSHik3FRX--