From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFRpP-0000WT-Ua for qemu-devel@nongnu.org; Mon, 17 Feb 2014 12:18:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFRpJ-0007qV-Rr for qemu-devel@nongnu.org; Mon, 17 Feb 2014 12:17:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFRpJ-0007py-Jo for qemu-devel@nongnu.org; Mon, 17 Feb 2014 12:17:53 -0500 Message-ID: <5302443B.3040701@redhat.com> Date: Mon, 17 Feb 2014 10:17:47 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392293009-13812-1-git-send-email-a.motakis@virtualopensystems.com> <1392293009-13812-15-git-send-email-a.motakis@virtualopensystems.com> In-Reply-To: <1392293009-13812-15-git-send-email-a.motakis@virtualopensystems.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dpW3diXpm6L4WG2VQSGG6i8GJPFi6AFRO" Subject: Re: [Qemu-devel] [PATCH v8 14/17] Add the vhost-user netdev backend to the command line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antonios Motakis , qemu-devel@nongnu.org, snabb-devel@googlegroups.com Cc: Stefan Hajnoczi , mst@redhat.com, Michael Tokarev , Markus Armbruster , n.nikolaev@virtualopensystems.com, Luiz Capitulino , Anthony Liguori , lukego@gmail.com, Paolo Bonzini , tech@virtualopensystems.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dpW3diXpm6L4WG2VQSGG6i8GJPFi6AFRO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/13/2014 05:03 AM, Antonios Motakis wrote: > The supplied chardev id will be inspected for supported options. Only > a socket backend, with a set path (i.e. a Unix socket) and optionally > the server parameter set, will be allowed. Other options (nowait, telne= t) > will make the chardev unusable and the netdev will not be initialised. >=20 > Additional checks for validity: > - requires `-mempath ...,share=3Don` > - requires `-device virtio-net-*` >=20 > The `vhostforce` option is uset to force vhost-net when we deal with no= -MSIX > guest. >=20 > Signed-off-by: Antonios Motakis > Signed-off-by: Nikolay Nikolaev > --- QMP review only: > +++ b/qapi-schema.json > @@ -3104,6 +3104,22 @@ > '*devname': 'str' } } > =20 > ## > +# @NetdevVhostUserOptions > +# > +# Vhost-user network backend > +# > +# @path: control socket path > +# > +# @vhostforce: #optional vhost on for non-MSIX virtio guests What's the default value when this is omitted? > +# > +# Since 2.0 > +## > +{ 'type': 'NetdevVhostUserOptions', > + 'data': { > + 'chardev': 'str', > + '*vhostforce': 'bool' } } Kill the TABs. The rest of this file uses spaces. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --dpW3diXpm6L4WG2VQSGG6i8GJPFi6AFRO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTAkQ7AAoJEKeha0olJ0NqxagH/jebn07OTne4nqPaF+7UPifX +5/WEMflYYG5Lu18pFkC71QyDVirwOZPxf+SY5iRv4vhhvsdZUk48ivF9F5zZP89 yjqAQkMbekG2TgY/2W/Xvmi3Kv8shsQmUAbhRpIgFPA2UKJYIX6+iZju6uDjA7vR o3K49Iu++7guRacBzQRROZi+o9bYdzEehaH0YBpFCKbZ7mScJdbrTnA+0ZwD+3qU zUK0+r3rqoFLy10cRcVqiESl4qK8sFoKTfw5kbxDS3xn6o6lerVvM5SLTuTQafMu 7lsdGi4SwHAZmYmJa4Algt0rVVdetPLP8s/YNX/OFBD05kOeIlnyyG8rvPCau7Y= =L5vy -----END PGP SIGNATURE----- --dpW3diXpm6L4WG2VQSGG6i8GJPFi6AFRO--