From: Eric Blake <eblake@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PULL v2 46/49] qdev: Add enum property types to QAPI schema
Date: Mon, 17 Feb 2014 15:30:34 -0700 [thread overview]
Message-ID: <53028D8A.5060500@redhat.com> (raw)
In-Reply-To: <1392675899-21210-47-git-send-email-afaerber@suse.de>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On 02/17/2014 03:24 PM, Andreas Färber wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> +++ b/qapi-schema.json
> @@ -28,7 +28,65 @@
> 'data': [ 'GenericError', 'CommandNotFound', 'DeviceEncrypted',
> 'DeviceNotActive', 'DeviceNotFound', 'KVMMissingCap' ] }
>
> +
> +##
> +# LostTickPolicy:
...
> +
> ##
> +# BiosAtaTranslation:
> +#
...
> +
> # @add_client
Oops - we lost the ## header before add_client. Sounds like a followup
patch might be called for, unless you are okay tweaking the pull request.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-02-17 22:30 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 22:24 [Qemu-devel] [PULL v2 00/49] QOM devices patch queue 2014-02-17 Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 01/49] qtest: don't report signals if qtest driver enabled Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 02/49] ppcemb-softmmu: Drop Mac and e500 emulation Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 03/49] target-ppc: Make ppc40x CPUs available in ppcemb Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 04/49] tests: Fix gcov paths for relocated device sources Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 05/49] qom-test: Run for all available machines Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 06/49] qom-test: Test shutdown in addition to startup Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 07/49] tests: Run qom-test for every architecture Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 08/49] nand: Don't use qdev_create() in nand_init() Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 09/49] i2c: Rename i2c_bus to I2CBus Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 10/49] pxa2xx: QOM'ify I2C slave Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 11/49] tosa: QOM'ify DAC Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 12/49] z2: QOM'ify AER915 Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 13/49] wm8750: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 14/49] ssd0303: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 15/49] max7310: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 16/49] lm832x: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 17/49] ds1338: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 18/49] twl92230: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 19/49] i2c: Drop FROM_I2C_SLAVE() macro Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 20/49] tests: Add e1000 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 21/49] tests: Add vmxnet3 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 22/49] tests: Add rtl8139 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 23/49] tests: Add pcnet qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 24/49] tests: Add eepro100 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 25/49] tests: Add ne2000 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 26/49] tests: Add virtio-net qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 27/49] tests: Add tpci200 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 28/49] tests: Add ipoctal232 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 29/49] ipack: Convert to QOM realize Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 30/49] ipack: QOM parent field cleanup for IPackBus Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 31/49] ipack: QOM parent field cleanup for IPackDevice Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 32/49] ipoctal232: QOM parent field cleanup Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 33/49] ipack: Move IndustryPack out of hw/char/ Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 34/49] qtest: Don't segfault with invalid -qtest option Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 35/49] qapi: Add size parser to StringInputVisitor Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 36/49] qdev: Sizes are now parsed by StringInputVisitor Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 37/49] qdev: Remove legacy parsers for hex8/32/64 Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 38/49] qdev: Legacy properties are now read-only Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 39/49] qdev: Legacy properties are just strings Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 40/49] qdev: Inline qdev_prop_parse() Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 41/49] qapi: Add human mode to StringOutputVisitor Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 42/49] qdev: Use human mode in "info qtree" Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 43/49] qdev: Remove most legacy printers Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 44/49] qdev: Remove hex8/32/64 property types Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 45/49] block: Handle "rechs" and "large" translation options Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 46/49] qdev: Add enum property types to QAPI schema Andreas Färber
2014-02-17 22:30 ` Eric Blake [this message]
2014-02-18 8:05 ` Paolo Bonzini
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 47/49] qdev: Use QAPI type names for properties Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 48/49] qapi: Refine human printing of sizes Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 49/49] qtest: Include system headers before user headers Andreas Färber
2014-02-20 15:02 ` [Qemu-devel] [PULL v2 00/49] QOM devices patch queue 2014-02-17 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53028D8A.5060500@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).