From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40151)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1WFaBu-0007uZ-B1
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 21:13:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1WFaBg-0005um-1u
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 21:13:46 -0500
Received: from e39.co.us.ibm.com ([32.97.110.160]:37284)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mrhines@linux.vnet.ibm.com>) id 1WFaBf-0005uX-Pv
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 21:13:31 -0500
Received: from /spool/local
	by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mrhines@linux.vnet.ibm.com>;
	Mon, 17 Feb 2014 19:13:30 -0700
Message-ID: <5302C1C2.9090802@linux.vnet.ibm.com>
Date: Tue, 18 Feb 2014 10:13:22 +0800
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <5231C6FC.3060506@gmail.com> <20140216023304.1350.73103@loki>
In-Reply-To: <20140216023304.1350.73103@loki>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak
	InetSocketAddress
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>, Frank <frank.yangjie@gmail.com>, qemu-stable@nongnu.org
Cc: Isaku Yamahata <yamahata@private.email.ne.jp>, qemu-devel@nongnu.org, Michael R Hines <mrhines@us.ibm.com>, lilei@linux.vnet.ibm.com

On 02/16/2014 10:33 AM, Michael Roth wrote:
> Quoting Frank (2013-09-12 08:51:56)
>> It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu_rdma_data_init().
>>
>>  From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001
>> From: Frank Yang <frank.yangjie@gmail.com>
>> Date: Thu, 12 Sep 2013 21:37:56 +0800
>> Subject: [PATCH] rdma: memory leak InetSocketAddress
>>
>> Signed-off-by: Frank Yang <frank.yangjie@gmail.com>
> Ping, looking to pull this in for 1.7.1

Actually, this fix is not fully correct. Let me re-send.

- Michael

>> ---
>>   migration-rdma.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/migration-rdma.c b/migration-rdma.c
>> index 05a155b..bcbe2d2 100644
>> --- a/migration-rdma.c
>> +++ b/migration-rdma.c
>> @@ -2512,6 +2512,7 @@ static void *qemu_rdma_data_init(const char *host_port, Error **errp)
>>           }
>>       }
>>
>> +    qapi_free_InetSocketAddress(addr);
>>       return rdma;
>>   }
>>
>> -- 
>> 1.8.3.msysgit.0
>>
>> -- 
>> Frank
>