From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFe0k-0006KM-TL for qemu-devel@nongnu.org; Tue, 18 Feb 2014 01:18:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFe0g-0006fe-Mg for qemu-devel@nongnu.org; Tue, 18 Feb 2014 01:18:30 -0500 Received: from [222.73.24.84] (port=23998 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFe0g-0006ch-8s for qemu-devel@nongnu.org; Tue, 18 Feb 2014 01:18:26 -0500 Message-ID: <5302FACD.1050902@cn.fujitsu.com> Date: Tue, 18 Feb 2014 14:16:45 +0800 From: Qiao Nuohan MIME-Version: 1.0 References: <1390890126-17377-1-git-send-email-qiaonuohan@cn.fujitsu.com> <20140211120056.0c51826e@redhat.com> <20140217125126.50346e20@redhat.com> In-Reply-To: <20140217125126.50346e20@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v8 00/13] Make 'dump-guest-memory' dump in kdump-compressed format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: stefanha@gmail.com, qemu-devel@nongnu.org, anderson@redhat.com, pbonzini@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, lersek@redhat.com, afaerber@suse.de On 02/18/2014 01:51 AM, Luiz Capitulino wrote: > On Tue, 11 Feb 2014 12:00:56 -0500 > Luiz Capitulino wrote: > >> On Tue, 28 Jan 2014 14:21:53 +0800 >> qiaonuohan wrote: >> >>> Hi, all >>> >>> The last version is here: >>> http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg00209.html >>> >>> Command 'dump-guest-memory' was introduced to dump guest's memory. But = the >>> vmcore's format is only elf32 or elf64. The message is here: >>> http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg03379.html >>> >>> Compared with migration, the missing of compression feature means regre= ssion >>> to 'dump-guest-memory'. So we post these patches to make 'dump-guest-me= mory' be >>> able to dump guest's in kdump-compressed format. Then vmcore can be much >>> smaller, and easily to be delivered. >>> >>> The kdump-compressed format is *linux specific* *linux standard* crash = dump >>> format used in kdump framework. The kdump-compressed format is readable= only >>> with the crash utility, and it can be smaller than the ELF format becau= se of >>> the compression support. To get more detailed information about >>> kdump-compressed format, please refer to the following URL: >>> http://sourceforge.net/projects/makedumpfile/ >> >> I did what was requested by Paolo. I applied patches 1 to 12 and will wa= it >> for the rework on patch 13. > > Unfortunately this series doesn't build on 32-bit hosts, so I had to drop= it > from my queue (see error below). Can you please do the following: > > 1. Fix the build > 2. Add new patch 13/13 to the series > 3. Add Ekaterina's patch to your series > > Thanks. Here's the error message: > > ar: creating libfdt/libfdt.a > /root/qmp-unstable/dump.c: In function =E2=80=98write=5Fdump=5Fpages=E2= =80=99: > /root/qmp-unstable/dump.c:1356:21: error: passing argument 2 of =E2=80=98= compress2=E2=80=99 from incompatible pointer type [-Werror] > Z=5FBEST=5FSPEED) =3D=3D Z=5FOK)&& (size=5Fout< s= ->page=5Fsize)) { > ^ > In file included from /root/qmp-unstable/dump.c:28:0: > /usr/include/zlib.h:1174:21: note: expected =E2=80=98uLongf *=E2=80=99 bu= t argument is of type =E2=80=98size=5Ft *=E2=80=99 > ZEXTERN int ZEXPORT compress2 OF((Bytef *dest, uLongf *destLen, > ^ > cc1: all warnings being treated as errors > make[1]: *** [dump.o] Error 1 > make: *** [subdir-aarch64-softmmu] Error 2 > make: *** Waiting for unfinished jobs.... > /root/qmp-unstable/dump.c: In function =E2=80=98write=5Fdump=5Fpages=E2= =80=99: > /root/qmp-unstable/dump.c:1356:21: error: passing argument 2 of =E2=80=98= compress2=E2=80=99 from incompatible pointer type [-Werror] > Z=5FBEST=5FSPEED) =3D=3D Z=5FOK)&& (size=5Fout< s= ->page=5Fsize)) { > ^ > In file included from /root/qmp-unstable/dump.c:28:0: > /usr/include/zlib.h:1174:21: note: expected =E2=80=98uLongf *=E2=80=99 bu= t argument is of type =E2=80=98size=5Ft *=E2=80=99 > ZEXTERN int ZEXPORT compress2 OF((Bytef *dest, uLongf *destLen, > ^ > cc1: all warnings being treated as errors > make[1]: *** [dump.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [subdir-alpha-softmmu] Error 2 > > Hello Luiz, It seems both zlib and lzo will output the error message because of the incompatible type. And I have fixed patches and sent them to the qemu list. P.S. lzo/snappy will need '--enable-lzo' or '--enable-snappy' at configure. --=20 Regards Qiao Nuohan =