From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFgpa-0000N7-Tr for qemu-devel@nongnu.org; Tue, 18 Feb 2014 04:19:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFgpS-00015E-8p for qemu-devel@nongnu.org; Tue, 18 Feb 2014 04:19:10 -0500 Received: from mail-ea0-x22b.google.com ([2a00:1450:4013:c01::22b]:44286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFgpS-000154-1h for qemu-devel@nongnu.org; Tue, 18 Feb 2014 04:19:02 -0500 Received: by mail-ea0-f171.google.com with SMTP id f15so7682049eak.2 for ; Tue, 18 Feb 2014 01:19:01 -0800 (PST) Sender: Paolo Bonzini Message-ID: <53032581.7050406@redhat.com> Date: Tue, 18 Feb 2014 10:18:57 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <52DFB382.5080002@redhat.com> In-Reply-To: <52DFB382.5080002@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/4] X86/KVM: enable Intel MPX for KVM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Liu, Jinsong" Cc: "gleb@redhat.com" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "qemu-devel@nongnu.org" , "hpa@zytor.com" , "Ren, Qiaowei" Il 22/01/2014 13:03, Paolo Bonzini ha scritto: > Il 22/01/2014 06:29, Liu, Jinsong ha scritto: >> These patches are version 3 to enalbe Intel MPX for KVM. >> >> Version 1: >> * Add some Intel MPX definiation >> * Fix a cpuid(0x0d, 0) exposing bug, dynamic per XCR0 features >> enable/disable >> * vmx and msr handle for MPX support at KVM >> * enalbe MPX feature for guest >> >> Version 2: >> * remove generic MPX definiation, Qiaowei's patch has add the >> definiation at kernel side >> * add MSR_IA32_BNDCFGS to msrs_to_save >> >> Version 3: >> * rebase on latest kernel, which include Qiaowei's MPX common >> definiation pulled from HPA's tree > > I am afraid there is still some work to do on these patches, so they > need to be delayed to 3.15. > > Patch 1: > this seems mostly separate from the rest of the MPX work. I > commented on the missing "ULL" suffix, but I would also like to > understand why you put this patch in this series. > > Patch 2: > As remarked in the reply to this patch: > - the vmx_disable_intercept_for_msr has to be unconditional > - you need a new kvm_x86_ops member mpx_supported, to disable > MPX whenever the two VMX controls are not available. > > Patch 3: > this patch needs to be rebased. Apart from that it is fine, > but please move the VMX bits together with patch 2, and the > other bits together with patch 4. > > Patch 4: > this patch needs to be rebased and to use the new mpx_supported > member > > If you also want to look at nested VMX support for MPX, that would be > nice. It should not be hard. Otherwise we can take care of that later. > > Thanks for your work, > > Paolo Are you going to send v4? Paolo