From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure
Date: Tue, 18 Feb 2014 11:07:53 +0100 [thread overview]
Message-ID: <530330F9.5070608@redhat.com> (raw)
In-Reply-To: <20140218090504.GB32585@stefanha-thinkpad.redhat.com>
Il 18/02/2014 10:05, Stefan Hajnoczi ha scritto:
>> > SIGABRT is normally synchronous enough: it's sent by abort(). But of
>> > course, nothing stops the user from kill -ABRT. Or GLib from calling
>> > abort() in some place where an attempt to reenter it crashes & burns.
>> > Not sure I'd care, but I'm pretty sure I don't care for freeing stuff on
>> > exit :)
> Yes, SIGABRT is synchronous for all purposes. So the only danger is
> that g_string_free() or g_free() could fail while we're in
> g_assert(false). But they don't, which makes sense because they are
> totally unrelated to g_assert() and therefore can handle re-entrancy.
If malloc aborts due to a double free or other similar problem, you may
risk reentering it.
Paolo
next prev parent reply other threads:[~2014-02-18 10:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 15:44 [Qemu-devel] [PATCH 0/3] qtest: avoid pidfile and QEMU process leaks Stefan Hajnoczi
2014-02-17 15:44 ` [Qemu-devel] [PATCH 1/3] qtest: drop unused child_pid field Stefan Hajnoczi
2014-02-17 15:44 ` [Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process Stefan Hajnoczi
2014-02-17 16:44 ` Markus Armbruster
2014-02-18 9:00 ` Stefan Hajnoczi
2014-02-18 9:53 ` Markus Armbruster
2014-02-17 15:44 ` [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure Stefan Hajnoczi
2014-02-17 16:16 ` Paolo Bonzini
2014-02-17 17:00 ` Markus Armbruster
2014-02-18 9:05 ` Stefan Hajnoczi
2014-02-18 10:05 ` Markus Armbruster
2014-02-18 10:23 ` Paolo Bonzini
2014-02-18 10:43 ` Markus Armbruster
2014-02-18 14:38 ` Stefan Hajnoczi
2014-02-18 10:07 ` Paolo Bonzini [this message]
2014-02-18 10:17 ` Daniel P. Berrange
2014-02-18 10:23 ` Paolo Bonzini
2014-02-17 16:49 ` Markus Armbruster
2014-02-17 16:56 ` Paolo Bonzini
2014-02-18 9:17 ` Stefan Hajnoczi
2014-02-18 9:55 ` Markus Armbruster
2014-02-18 14:44 ` Stefan Hajnoczi
2014-02-18 14:56 ` Peter Maydell
2014-02-18 10:02 ` Markus Armbruster
2014-02-18 14:38 ` Stefan Hajnoczi
2014-02-18 14:52 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530330F9.5070608@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).