From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40184)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WFjm6-0000lZ-9W
	for qemu-devel@nongnu.org; Tue, 18 Feb 2014 07:27:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WFjlx-0001DN-O2
	for qemu-devel@nongnu.org; Tue, 18 Feb 2014 07:27:46 -0500
Received: from mail-qa0-x236.google.com ([2607:f8b0:400d:c00::236]:59243)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WFjlx-0001D3-Ii
	for qemu-devel@nongnu.org; Tue, 18 Feb 2014 07:27:37 -0500
Received: by mail-qa0-f54.google.com with SMTP id i13so23454249qae.13
	for <qemu-devel@nongnu.org>; Tue, 18 Feb 2014 04:27:37 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <530351B4.1010402@redhat.com>
Date: Tue, 18 Feb 2014 13:27:32 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1392050814-31814-1-git-send-email-mst@redhat.com>	<CAFEAcA8SGApDRa06BJSqU_uxrQsG35KAoPUU+P_Liy0cr5hO+g@mail.gmail.com>
	<alpine.DEB.2.02.1402181208470.27926@kaball.uk.xensource.com>
In-Reply-To: <alpine.DEB.2.02.1402181208470.27926@kaball.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 00/20] acpi,pc,pci fixes and enhancements
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: xen-devel@lists.xensource.com, "Michael S. Tsirkin" <mst@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, armbru@redhat.com, Anthony Liguori <aliguori@amazon.com>, Anthony.Perard@citrix.com

Il 18/02/2014 13:16, Stefano Stabellini ha scritto:
> It looks like that this series breaks disk unplug
> (hw/ide/piix.c:pci_piix3_xen_ide_unplug).
>
> I bisected it and the problem is caused by:
>
> commit 5e95494380ecf83c97d28f72134ab45e0cace8f9
> Author: Igor Mammedov <imammedo@redhat.com>
> Date:   Wed Feb 5 16:36:52 2014 +0100
>
>     hw/pci: switch to a generic hotplug handling for PCIDevice
>
>     make qdev_unplug()/device_set_realized() to call hotplug handler's
>     plug/unplug methods if available and remove not needed anymore
>     hot(un)plug handling from PCIDevice.
>
>     In case if hotplug handler is not available, revert to the legacy
>     hotplug method for compatibility with not yet converted buses.
>
>     Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>     Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
>

What exactly breaks?

Paolo