From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFkdl-0006Jy-Ju for qemu-devel@nongnu.org; Tue, 18 Feb 2014 08:23:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFkdh-0001Gc-KV for qemu-devel@nongnu.org; Tue, 18 Feb 2014 08:23:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFkdh-0001Fs-AZ for qemu-devel@nongnu.org; Tue, 18 Feb 2014 08:23:09 -0500 Message-ID: <53035EB8.4050206@redhat.com> Date: Tue, 18 Feb 2014 06:23:04 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392726818-14606-1-git-send-email-vincent.kherbache@inria.fr> In-Reply-To: <1392726818-14606-1-git-send-email-vincent.kherbache@inria.fr> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lrCopthnaSdXnxQlekxnuTvb17GL9GhDu" Subject: Re: [Qemu-devel] [PATCH] kvm: fix kvm_set_migration_log() behavior List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincent KHERBACHE , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, gleb@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lrCopthnaSdXnxQlekxnuTvb17GL9GhDu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/18/2014 05:33 AM, Vincent KHERBACHE wrote: > The test (!!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES) =3D=3D enable) is wr= ong because=20 > the condition is valid when enable =3D 0 and current dirty log memory f= lag is set. > As a consequence kvm_log_global_stop() does not stop the KVM dirty log > tracking: kvm_set_migration_log(0) didn't do its job. > So instead I propose to use kvm_slot_dirty_pages_log_change() which cor= rectly > compare the memory flags (old/new). >=20 > Signed-off-by: Vincent KHERBACHE > --- > kvm-all.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) >=20 > - return err; > - } > + err =3D kvm_slot_dirty_pages_log_change(mem, (bool)enable); Is this a v2 post? Any reason you reposted without addressing my earlier review? https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg02840.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lrCopthnaSdXnxQlekxnuTvb17GL9GhDu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTA164AAoJEKeha0olJ0NqmMsIALAXimkNfs1xRGnQrLzWxjMZ 4PQGzKm8/QbaWp+KsYHGh/EXMacTSm31x5mfAOaej+HNy5nm1JBtheEfwu2GwB9o YGadAqQrMyNrzFR6rqFcbdRL4FhLOFZFmiwH4CPtjjVfprahOXGpFvg1ZiXe/wi4 HyuvAKW45fEIvk/JxnwqJ+6gtMrTsvOVDyNRwU6YG/k4aGyrcV3v8Fqu0VQhyrGn K1C57FCooJ6qyX5JG6LruOwqSxsXx+TnDylFLb8loMSNvxXAWeSiWg5Zdx7qVnt1 qn6+mq0hTY1Lx2xs4b/dkWmNce1fsqhqk9U7YypRGvcBSlO/cwbKVoGrG8+JGOQ= =6euz -----END PGP SIGNATURE----- --lrCopthnaSdXnxQlekxnuTvb17GL9GhDu--