qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: peter.crosthwaite@xilinx.com, mst@redhat.com,
	qemu-devel@nongnu.org, anthony@codemonkey.ws,
	imammedo@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] qom: add object_property_is_set
Date: Tue, 18 Feb 2014 18:26:21 +0100	[thread overview]
Message-ID: <530397BD.6090905@redhat.com> (raw)
In-Reply-To: <1392743460.3076.10.camel@localhost.localdomain>

Il 18/02/2014 18:11, Marcel Apfelbaum ha scritto:
> It is used to replace qemu_opt_get_bool that provides a
> parameter for a default value. In this case we need to
> differentiate "no value" from "false."

But what would the getter return in that case?  If possible, it's better 
to initialize to the default value in an instance_init method.

> I could send it with QemuMachine QOMify feature,
> but this will be a fairly large series and I *really* want
> to minimize it as much as I can, this is why I release small,
> stand-alone patches, that fixes some issue (see [Qemu-devel]
> [PATCH] qapi: output visitor crashes qemu if it encounters a NULL value),
> or adds a fairly useful feature like this one.

It depends, features are not necessarily useful without users.

Paolo

  reply	other threads:[~2014-02-18 17:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 16:46 [Qemu-devel] [PATCH] qom: add object_property_is_set Marcel Apfelbaum
2014-02-18 16:51 ` Paolo Bonzini
2014-02-18 17:11   ` Marcel Apfelbaum
2014-02-18 17:26     ` Paolo Bonzini [this message]
2014-02-18 17:49       ` Andreas Färber
2014-02-19  7:11         ` Marcel Apfelbaum
2014-02-19  7:03       ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530397BD.6090905@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=imammedo@redhat.com \
    --cc=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).