From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFowy-0008L3-Nu for qemu-devel@nongnu.org; Tue, 18 Feb 2014 12:59:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFowr-0006SG-2E for qemu-devel@nongnu.org; Tue, 18 Feb 2014 12:59:20 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:59904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFowq-0006Rn-Ro for qemu-devel@nongnu.org; Tue, 18 Feb 2014 12:59:12 -0500 Message-ID: <53039F50.2020207@inria.fr> Date: Tue, 18 Feb 2014 18:58:40 +0100 From: Vincent KHERBACHE MIME-Version: 1.0 References: <1392726818-14606-1-git-send-email-vincent.kherbache@inria.fr> <53038754.7000304@redhat.com> In-Reply-To: <53038754.7000304@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] kvm: fix kvm_set_migration_log() behavior List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: gleb@redhat.com Le 18/02/2014 17:16, Paolo Bonzini a écrit : > This patch is not correct, because it introduces another one: if dirty > logging was enabled on the memory region (kvm_dirty_pages_log_change), > it will be disabled after migration. Yes you're right that was my initial goal, I didn't distinguish the two cases. > Note that the effects of > kvm_set_migration_log and kvm_dirty_pages_log_change should be logically > ORed. OK, but that's not really the case (see next comment) > Can you explain better the problem? I cannot see anything wrong in the > code, though it is not the clearest. The problem is that if dirty logging is enabled by kvm_set_migration_log(1) it will NOT be disabled by a kvm_set_migration_log(0). So, if this behavior is 'normal', kvm_log_global_stop (which call kvm_set_migration_log) can not be used independently ? Also, what I don't understand is why kvm_log_global_start/stop and kvm_log_start/stop are so different: kvm_set_migration_log VS kvm_dirty_pages_log_change. Thank you for the support. Regards, -- Vincent KHERBACHE