From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFq78-0002Mt-Nq for qemu-devel@nongnu.org; Tue, 18 Feb 2014 14:13:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFq73-0008EM-Mf for qemu-devel@nongnu.org; Tue, 18 Feb 2014 14:13:54 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60815 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFq73-0008EF-Bs for qemu-devel@nongnu.org; Tue, 18 Feb 2014 14:13:49 -0500 Message-ID: <5303B0EA.5040902@suse.de> Date: Tue, 18 Feb 2014 20:13:46 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <52FE0535.2090205@suse.de> <20140218123844.9849.58557.stgit@bahia.lab.toulouse-stg.fr.ibm.com> In-Reply-To: <20140218123844.9849.58557.stgit@bahia.lab.toulouse-stg.fr.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/8] virtio endian-ambivalent target fixes (rebased) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: kwolf@redhat.com, peter.maydell@linaro.org, thuth@linux.vnet.ibm.com, mst@redhat.com, marc.zyngier@arm.com, rusty@rustcorp.com.au, agraf@suse.de, qemu-devel@nongnu.org, Cornelia Huck , stefanha@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com Am 18.02.2014 13:38, schrieb Greg Kurz: > On Fri, 14 Feb 2014 12:59:49 +0100 > Andreas F=C3=A4rber wrote: >=20 >> Hi, >> >> [...] >> >> It might've helped if Rusty had actually used our >> scripts/get_maintainer.pl script to CC people. While Anthony seems to >> have reviewed some patches (usually Reviewed-by should be before the >> final Signed-off-by fwiw), neither Stefan (virtio-net) nor Kevin >> (virtio-blk) nor Paolo (virtio-scsi) were CC'ed, and recently Michael >> stepped up as virtio maintainer, so maybe he can take them once ready. >> >> 1/7 looks okay to me; 3-7 are rather mechanical - people will need to >> review that those changes are sufficient for the current code base. >> We've since converted virtio devices to QOM realize, so a rebase is >> likely needed for such an "old" series. Hi, > Thank you Andreas for your support. :) >=20 > Here is a rebased patchset. Only the two first patches ("virtio_get_byt= eswap:" > and "virtio:") had to be updated actually. FWIW, this the very same pat= chset > I use, along with some ppc64 specific enablement code, to have function= nal > ppc64 LE guests. Some more support: ;) When you resend with Connie's fix, please send as top-level patchset, and labeled "PATCH v5" (or whatever the count ... I counted the one you replied to as v3). Please also don't forget to sign off all patches you send out, even if unchanged. Your [ ... ] comments should go right before your Sob (unless Rusty did sign them off). >=20 > --- >=20 > Greg Kurz (1): > hw/9pfs/virtio_9p_device: use virtio wrappers to access headers. "virtio-9p-device" (or just "virtio-9p") >=20 > Rusty Russell (7): > virtio_get_byteswap: function for endian-ambivalent targets using= virtio. > virtio: allow byte swapping for vring and config access > hw/net/virtio-net: use virtio wrappers to access headers. > hw/net/virtio-balloon: use virtio wrappers to access page frame n= umbers. > hw/block/virtio-blk: use virtio wrappers to access headers. > hw/scsi/virtio-scsi: use virtio wrappers to access headers. > hw/char/virtio-serial-bus: use virtio wrappers to access headers. While at it, some things you've copied... Usually subjects don't end in a full stop, similar to English headings. Opinions are divided on whether they should start with a capital letter. Generally, hw/foo/virtio-bar is redundant and could be just virtio-bar. http://git.qemu.org/?p=3Dqemu.git&a=3Dsearch&h=3DHEAD&st=3Dcommit&s=3Dvir= tio But it's not wrong and terribly important either. :) Regards, Andreas >=20 >=20 > hw/9pfs/virtio-9p-device.c | 3 + > hw/block/virtio-blk.c | 35 +++++----- > hw/char/virtio-serial-bus.c | 34 +++++----- > hw/net/virtio-net.c | 15 ++-- > hw/scsi/virtio-scsi.c | 33 +++++---- > hw/virtio/virtio-balloon.c | 3 + > hw/virtio/virtio.c | 38 ++++++----- > include/hw/virtio/virtio-access.h | 132 +++++++++++++++++++++++++++++= ++++++++ > include/hw/virtio/virtio.h | 2 + > stubs/Makefile.objs | 1=20 > stubs/virtio_get_byteswap.c | 6 ++ > 11 files changed, 228 insertions(+), 74 deletions(-) > create mode 100644 include/hw/virtio/virtio-access.h > create mode 100644 stubs/virtio_get_byteswap.c >=20 > Best Regards. >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg