From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFwBo-0001TL-1Y for qemu-devel@nongnu.org; Tue, 18 Feb 2014 20:43:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFwBf-0008Ne-47 for qemu-devel@nongnu.org; Tue, 18 Feb 2014 20:43:07 -0500 Received: from e7.ny.us.ibm.com ([32.97.182.137]:35974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFwBe-0008Na-V4 for qemu-devel@nongnu.org; Tue, 18 Feb 2014 20:42:59 -0500 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 18 Feb 2014 20:42:58 -0500 Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id B336CC90043 for ; Tue, 18 Feb 2014 20:42:51 -0500 (EST) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by b01cxnp22034.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s1J1gs3O6357498 for ; Wed, 19 Feb 2014 01:42:54 GMT Received: from d01av05.pok.ibm.com (localhost [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s1J1grlY022166 for ; Tue, 18 Feb 2014 20:42:54 -0500 Message-ID: <53040C14.7070401@linux.vnet.ibm.com> Date: Wed, 19 Feb 2014 09:42:44 +0800 From: "Michael R. Hines" MIME-Version: 1.0 References: <1392713429-18201-1-git-send-email-mrhines@linux.vnet.ibm.com> <1392713429-18201-3-git-send-email-mrhines@linux.vnet.ibm.com> <20140218103230.GD2662@work-vm> In-Reply-To: <20140218103230.GD2662@work-vm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 02/12] mc: timestamp migration_bitmap and KVM logdirty usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: GILR@il.ibm.com, SADEKJ@il.ibm.com, pbonzini@redhat.com, quintela@redhat.com, abali@us.ibm.com, qemu-devel@nongnu.org, EREZH@il.ibm.com, owasserm@redhat.com, onom@us.ibm.com, hinesmr@cn.ibm.com, isaku.yamahata@gmail.com, gokul@us.ibm.com, dbulkow@gmail.com, junqing.wang@cs2c.com.cn, BIRAN@il.ibm.com, lig.fnst@cn.fujitsu.com, "Michael R. Hines" On 02/18/2014 06:32 PM, Dr. David Alan Gilbert wrote: > * mrhines@linux.vnet.ibm.com (mrhines@linux.vnet.ibm.com) wrote: >> From: "Michael R. Hines" >> >> We also later export these statistics over QMP for better >> monitoring of micro-checkpointing as the workload changes. > > >> @@ -548,9 +568,11 @@ static int ram_save_block(QEMUFile *f, bool last_stage) >> /* XBZRLE overflow or normal page */ >> if (bytes_sent == -1) { >> bytes_sent = save_block_hdr(f, block, offset, cont, RAM_SAVE_FLAG_PAGE); >> - qemu_put_buffer_async(f, p, TARGET_PAGE_SIZE); >> - bytes_sent += TARGET_PAGE_SIZE; >> - acct_info.norm_pages++; >> + if (ret != RAM_SAVE_CONTROL_DELAYED) { >> + qemu_put_buffer_async(f, p, TARGET_PAGE_SIZE); >> + bytes_sent += TARGET_PAGE_SIZE; >> + acct_info.norm_pages++; >> + } >> } > Is that last change intended for this patch; it doesn't look > timestamp related. > > Dave > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > Oooops. I failed to split-out that patch correctly. How'd that get in there? =) - Michael