From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG2kI-0000vU-Ks for qemu-devel@nongnu.org; Wed, 19 Feb 2014 03:43:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WG2kA-00046I-8N for qemu-devel@nongnu.org; Wed, 19 Feb 2014 03:43:10 -0500 Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:36770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG2kA-00046B-3Y for qemu-devel@nongnu.org; Wed, 19 Feb 2014 03:43:02 -0500 Received: by mail-qc0-f180.google.com with SMTP id i17so84233qcy.11 for ; Wed, 19 Feb 2014 00:43:01 -0800 (PST) Sender: Paolo Bonzini Message-ID: <53046E90.2020705@redhat.com> Date: Wed, 19 Feb 2014 09:42:56 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <2b9b6745ac6f7a5b697f479d684b226505952701.1392794450.git.hutao@cn.fujitsu.com> <20140219081727.GB11157@G08FNSTD100614.fnst.cn.fujitsu.com> In-Reply-To: <20140219081727.GB11157@G08FNSTD100614.fnst.cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v18 11/14] qapi: make string input visitor parse int list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao , qemu-devel@nongnu.org Cc: imammedo@redhat.com, lersek@redhat.com, Wanlong Gao Il 19/02/2014 09:17, Hu Tao ha scritto: > Two problems: > > 1. the code is mostly copied from OptsVisitor. maybe we can share the > code? I think it's not a huge problem. Maybe OptsVisitor could be made to use a StringInputVisitor internally. > 2. int list is not implemented in string outout visitor. but there is > currently no user of it. Should we implement it or not? Yes, please. We probably will add sooner or later a qom-get/qom-set pair of HMP commands and these will use the string output visitor. Paolo