From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG3AY-0003Gu-31 for qemu-devel@nongnu.org; Wed, 19 Feb 2014 04:10:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WG3AS-0005O8-9o for qemu-devel@nongnu.org; Wed, 19 Feb 2014 04:10:18 -0500 Sender: Paolo Bonzini Message-ID: <530474F0.5000101@redhat.com> Date: Wed, 19 Feb 2014 10:10:08 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1392763356-29026-1-git-send-email-kroosec@gmail.com> In-Reply-To: <1392763356-29026-1-git-send-email-kroosec@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] object: Report type in error when not user creatable. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hani Benhabiles , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, lcapitulino@redhat.com Il 18/02/2014 23:42, Hani Benhabiles ha scritto: > Signed-off-by: Hani Benhabiles > --- > qmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qmp.c b/qmp.c > index d0d98e7..f556a04 100644 > --- a/qmp.c > +++ b/qmp.c > @@ -556,8 +556,8 @@ void object_add(const char *type, const char *id, const QDict *qdict, > } > > if (!object_dynamic_cast(obj, TYPE_USER_CREATABLE)) { > - error_setg(&local_err, "object '%s' isn't supported by object-add", > - id); > + error_setg(&local_err, "object type '%s' isn't supported by object-add", > + type); > goto out; > } > > Acked-by: Paolo Bonzini Paolo