From: Laszlo Ersek <lersek@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] bswap: Clean prototypes of st* functions
Date: Wed, 19 Feb 2014 11:16:55 +0100 [thread overview]
Message-ID: <53048497.1060701@redhat.com> (raw)
In-Reply-To: <1392786705-9730-1-git-send-email-sw@weilnetz.de>
On 02/19/14 06:11, Stefan Weil wrote:
> These modifications avoid type conversions for non optimized code.
>
> ld* function prototypes will follow later.
>
> [PATCH 1/2] bswap: Modify prototype of stb_p (avoid type
> [PATCH 2/2] bswap: Modify prototypes of st[wl]_{le,be}_p (avoid type
>
It probably wouldn't hurt to audit all call sites, but it does look
reasonable.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2014-02-19 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 5:11 [Qemu-devel] [PATCH 0/2] bswap: Clean prototypes of st* functions Stefan Weil
2014-02-19 5:11 ` [Qemu-devel] [PATCH 1/2] bswap: Modify prototype of stb_p (avoid type conversions) Stefan Weil
2014-02-19 5:11 ` [Qemu-devel] [PATCH 2/2] bswap: Modify prototypes of st[wl]_{le, be}_p " Stefan Weil
2014-02-19 5:19 ` Stefan Weil
2014-02-19 10:16 ` Laszlo Ersek [this message]
2014-02-22 12:06 ` [Qemu-devel] [Qemu-trivial] [PATCH 0/2] bswap: Clean prototypes of st* functions Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53048497.1060701@redhat.com \
--to=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).