From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG4DM-0000p3-VK for qemu-devel@nongnu.org; Wed, 19 Feb 2014 05:17:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WG4DG-0008Ks-OV for qemu-devel@nongnu.org; Wed, 19 Feb 2014 05:17:16 -0500 Message-ID: <53048497.1060701@redhat.com> Date: Wed, 19 Feb 2014 11:16:55 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1392786705-9730-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1392786705-9730-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] bswap: Clean prototypes of st* functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On 02/19/14 06:11, Stefan Weil wrote: > These modifications avoid type conversions for non optimized code. > > ld* function prototypes will follow later. > > [PATCH 1/2] bswap: Modify prototype of stb_p (avoid type > [PATCH 2/2] bswap: Modify prototypes of st[wl]_{le,be}_p (avoid type > It probably wouldn't hurt to audit all call sites, but it does look reasonable. Reviewed-by: Laszlo Ersek