From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37609)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WG5jL-0004CT-2c
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 06:54:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WG5jD-0005up-Uh
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 06:54:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:61879)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WG5jD-0005uP-NM
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 06:54:15 -0500
Message-ID: <53049B53.1050407@redhat.com>
Date: Wed, 19 Feb 2014 12:53:55 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1392794450.git.hutao@cn.fujitsu.com>	<b87b2fb5255071e1f47c02f25949f2c73c856652.1392794450.git.hutao@cn.fujitsu.com>
	<20140219105024.06c378d7@nial.usersys.redhat.com>
In-Reply-To: <20140219105024.06c378d7@nial.usersys.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v18 10/14] numa: add -numa node,
	memdev= option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, Hu Tao <hutao@cn.fujitsu.com>
Cc: lersek@redhat.com, qemu-devel@nongnu.org, Wanlong Gao <gaowanlong@cn.fujitsu.com>

Il 19/02/2014 10:50, Igor Mammedov ha scritto:
>> > +        numa_info[nodenr].node_mem = object_property_get_int(o, "size", NULL);
>> > +        numa_info[nodenr].node_memdev = MEMORY_BACKEND(o);
> if you make numa_info  QOM object node_memdev link<> property,
> then above hunk could be replaced with just setting link.
> And node_mem could be replaced with readonly property that reads size
> directly from memdev avoiding data duplication.
>
> As side-effect it numa_info will also become accessible for introspection
> using QOM interface. Something like:
>  qom-list /machine/memory-node[X]
>  qom-get /machine/memory-node[X]/memory_size

I agree, but I think we can do it on top.

Paolo