From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG6mM-0001HG-HT for qemu-devel@nongnu.org; Wed, 19 Feb 2014 08:01:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WG6mG-0001iI-FN for qemu-devel@nongnu.org; Wed, 19 Feb 2014 08:01:34 -0500 Received: from cantor2.suse.de ([195.135.220.15]:48409 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG6mG-0001hl-8O for qemu-devel@nongnu.org; Wed, 19 Feb 2014 08:01:28 -0500 Message-ID: <5304AB23.506@suse.de> Date: Wed, 19 Feb 2014 14:01:23 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1392800720-2765-1-git-send-email-mark.cave-ayland@ilande.co.uk> In-Reply-To: <1392800720-2765-1-git-send-email-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCHv3 0/2] sun4m: Implement Sun CG3 framebuffer for QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , qemu-devel@nongnu.org Am 19.02.2014 10:05, schrieb Mark Cave-Ayland: > This patchset provides QEMU with an implementation of the Sun CG3 8-bit > framebuffer. It is based upon Bob Breuer's original work which has been > rebased onto git master, and is now capable of running with an OpenBIOS= CG3=20 > FCode ROM instead of requiring copies of proprietary Sun ROMs. >=20 > The motivation behind this patch is that older operating systems such a= s > Debian Woody and Solaris (running OpenWindows) do not contain drivers f= or the > TCX framebuffer and as a result currently cannot run in graphical mode.= The > screenshots linked below show qemu-system-sparc successfully running bo= th=20 > Debian Woody and the Solaris 8 installer in graphical mode during testi= ng: >=20 > http://www.ilande.co.uk/tmp/debian-woody.png > http://www.ilande.co.uk/tmp/sol8-1.png > http://www.ilande.co.uk/tmp/sol8-2.png >=20 > The CG3 framebuffer is selected by passing -vga cg3 on the command line= to > qemu-system-sparc. If either -vga tcx is specified (or the -vga argumen= t is > omitted) then qemu-system-sparc defaults to using the existing TCX > framebuffer to maintain compatibility. >=20 > v3: > - Rebased to git master > - Fix DEBUG_CG3 macro > - Use register constants based upon Linux/BSD drivers > - Use qemu_log(LOG_UNIMP ... ) to capture unrecognised register acc= esses > - Rename device type from SUNW,cgthree to cgthree (matches OBP) > - Use error_report() instead of fprintf(stderr ... ) > - Convert from init to realizefn >=20 > v2: > - Rebased to git master > - Updated QEMU,cgthree.bin ROM to latest OpenBIOS version > - Added Peter Maydell to CC >=20 >=20 > Mark Cave-Ayland (2): > sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM > sun4m: Add Sun CG3 framebuffer initialisation function Reviewed-by: Andreas F=E4rber There's some lines we could extract from the realizefn into an instance_init, but can be done as follow-up when needed. Two small questions, are vram_size and prom_addr for compatibility? New convention for QOM properties would be dashes. Regards, Andreas >=20 > Makefile | 2 +- > default-configs/sparc-softmmu.mak | 1 + > hw/display/Makefile.objs | 1 + > hw/display/cg3.c | 384 +++++++++++++++++++++++++++++= ++++++++ > hw/sparc/sun4m.c | 62 +++++- > include/sysemu/sysemu.h | 1 + > pc-bios/QEMU,cgthree.bin | Bin 0 -> 850 bytes > pc-bios/README | 4 +- > vl.c | 24 +++ > 9 files changed, 473 insertions(+), 6 deletions(-) > create mode 100644 hw/display/cg3.c > create mode 100644 pc-bios/QEMU,cgthree.bin >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg