From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGAAl-0001ww-6Q for qemu-devel@nongnu.org; Wed, 19 Feb 2014 11:39:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGAAf-0005qK-D6 for qemu-devel@nongnu.org; Wed, 19 Feb 2014 11:38:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGAAf-0005q6-5r for qemu-devel@nongnu.org; Wed, 19 Feb 2014 11:38:53 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1JGcpL0004575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 19 Feb 2014 11:38:51 -0500 Message-ID: <5304DE1A.8040300@redhat.com> Date: Wed, 19 Feb 2014 09:38:50 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392822778-4823-1-git-send-email-kwolf@redhat.com> <1392822778-4823-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1392822778-4823-2-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7FL6VLapsd4Plt1xe6q0ramtpwFQ78Faf" Subject: Re: [Qemu-devel] [PATCH 1/7] qemu-img create: Detect options specified more than once List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7FL6VLapsd4Plt1xe6q0ramtpwFQ78Faf Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/19/2014 08:12 AM, Kevin Wolf wrote: > If you specified multiple -o options for qemu-img create, it would > silently ignore all but the last one. Similarly, for other options the > last occurence wins (which is at least a bit less surprising). Error ou= t s/occurence/occurrence/ > instead. For other options, erroring out is okay. But for -o, I would prefer if we could concatenate multiple -o as if they had been passed in one larger -o, rather than erroring out. That is, I'd rather treat: -o backing_file=3D/path/to/foo -o backing_fmt=3Dqcow2 as a synonym of -o backing_file=3D/path/to/foo,backing_fmt=3Dqcow2 >=20 > The only exception is a -o help option, which may be added to any valid= > qemu-img create command and ignores all other options. If you consider my above request for concatenating multiple -o options, rather than rejecting duplicates, then that means: -o backing_file=3D/path/to/foo,help would have to do the right thing about displaying help. I also have the complaint that: qemu-img create -o help -f qcow2 does not tell me the qcow2 specific options; I have to do something like:= qemu-img create -o help -f qcow2 /dev/null It would be nice if we could make -o help smarter so that it no longer requires the presence of a file name (probably a separate patch). In other words, I like that your series is trying to improve things, but I don't think it is making the right improvement. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7FL6VLapsd4Plt1xe6q0ramtpwFQ78Faf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTBN4aAAoJEKeha0olJ0NqficH/iiGqCB2un+kAV1BUVfV7uO1 m41+Hh9m3ZcGdAXNHlXAZgaQGERbXmr1a4bfvaLvifINGUS6w3a5MxHvvQzTBdh0 t6OIR6oM8vfgpUtVlCFecmSCRtgxvdBQXUn7TGZodSHuoMYodwvuLv/eSnJc4MdK WVbCCrVG/wQLMHbSA+A2iLBbH3XVwVMaD9iTJJW5JNNRVwZBOs+nCwc3usfAR1vH cqoDzFYItwWa3hUDEfE4bNWewsyWalxdVmGgJp5fjSlKu6cG9HJtOD1q71B8ZHLd 0wtCkSdi0+o9I2QfKk1jkZ8JRKttQrujUWNZjfGyaJ0i+YnvCxMaDikOFVYBDX8= =jOjB -----END PGP SIGNATURE----- --7FL6VLapsd4Plt1xe6q0ramtpwFQ78Faf--