Re: [Qemu-devel] [PATCHv3 0/2] sun4m: Implement Sun CG3 framebuffer for QEMU

[Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>]

On 19/02/14 13:01, Andreas Färber wrote:

> Am 19.02.2014 10:05, schrieb Mark Cave-Ayland:
>> This patchset provides QEMU with an implementation of the Sun CG3 8-bit
>> framebuffer. It is based upon Bob Breuer's original work which has been
>> rebased onto git master, and is now capable of running with an OpenBIOS CG3
>> FCode ROM instead of requiring copies of proprietary Sun ROMs.
>>
>> The motivation behind this patch is that older operating systems such as
>> Debian Woody and Solaris (running OpenWindows) do not contain drivers for the
>> TCX framebuffer and as a result currently cannot run in graphical mode. The
>> screenshots linked below show qemu-system-sparc successfully running both
>> Debian Woody and the Solaris 8 installer in graphical mode during testing:
>>
>> http://www.ilande.co.uk/tmp/debian-woody.png
>> http://www.ilande.co.uk/tmp/sol8-1.png
>> http://www.ilande.co.uk/tmp/sol8-2.png
>>
>> The CG3 framebuffer is selected by passing -vga cg3 on the command line to
>> qemu-system-sparc. If either -vga tcx is specified (or the -vga argument is
>> omitted) then qemu-system-sparc defaults to using the existing TCX
>> framebuffer to maintain compatibility.
>>
>> v3:
>>      - Rebased to git master
>>      - Fix DEBUG_CG3 macro
>>      - Use register constants based upon Linux/BSD drivers
>>      - Use qemu_log(LOG_UNIMP ... ) to capture unrecognised register accesses
>>      - Rename device type from SUNW,cgthree to cgthree (matches OBP)
>>      - Use error_report() instead of fprintf(stderr ... )
>>      - Convert from init to realizefn
>>
>> v2:
>>      - Rebased to git master
>>      - Updated QEMU,cgthree.bin ROM to latest OpenBIOS version
>>      - Added Peter Maydell to CC
>>
>>
>> Mark Cave-Ayland (2):
>>    sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM
>>    sun4m: Add Sun CG3 framebuffer initialisation function
>
> Reviewed-by: Andreas Färber<afaerber@suse.de>

Thanks a lot!

> There's some lines we could extract from the realizefn into an
> instance_init, but can be done as follow-up when needed.

Okay great. I guess that it's always possible to move something from 
realizefn into instance_init, but not the other way around.

> Two small questions, are vram_size and prom_addr for compatibility? New
> convention for QOM properties would be dashes.

They are only named that way because that's the way they were in tcx.c. 
Do you want me to adjust and resend?


ATB,

Mark.