From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGFKg-0004Zl-9r for qemu-devel@nongnu.org; Wed, 19 Feb 2014 17:09:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGFKZ-0007Ap-5c for qemu-devel@nongnu.org; Wed, 19 Feb 2014 17:09:34 -0500 Received: from mail-ee0-x22f.google.com ([2a00:1450:4013:c00::22f]:41295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGFKY-00078j-QR for qemu-devel@nongnu.org; Wed, 19 Feb 2014 17:09:27 -0500 Received: by mail-ee0-f47.google.com with SMTP id d49so524517eek.20 for ; Wed, 19 Feb 2014 14:09:26 -0800 (PST) Sender: Paolo Bonzini Message-ID: <53052B92.7080305@redhat.com> Date: Wed, 19 Feb 2014 23:09:22 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1392827321-10205-1-git-send-email-roland@kernel.org> <5304E4E4.10703@redhat.com> <5304F3D4.9060501@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roland Dreier , =?ISO-8859-1?Q?Andreas_F=E4?= =?ISO-8859-1?Q?rber?= Cc: qemu-devel@nongnu.org Il 19/02/2014 19:18, Roland Dreier ha scritto: > On Wed, Feb 19, 2014 at 10:11 AM, Andreas Färber wrote: >> > HEX64 will conflict with your patches in the pending pull. > I'm not aware of the issue. Is there a better tree for me to work > against than qemu.git master? No, I'll take care of rebasing and won't send a pull request until Andreas's pending pull request is in. >> > Also I notice that underscores are being used in new properties - >> > oversight or intentional? > Forgive me, but I'm not that famliar with the customs for naming > device properties in QEMU. What would a better choice be? Oversight, but it convinces me more that we should just match [_-] also against the other in the pair. Must find time to write that patch... Paolo