From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55903)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1WGPIy-0005Xl-IU
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 03:48:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1WGPIt-0000YR-AN
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 03:48:28 -0500
Received: from s16892447.onlinehome-server.info ([82.165.15.123]:34875)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1WGPIt-0000YL-3T
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 03:48:23 -0500
Message-ID: <5305C0C8.8060307@ilande.co.uk>
Date: Thu, 20 Feb 2014 08:46:00 +0000
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
MIME-Version: 1.0
References: <52C0B576.6060102@caramail.com>
In-Reply-To: <52C0B576.6060102@caramail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] sparc: Set HostID in NVRAM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Olivier Danet <odanet@caramail.com>
Cc: qemu-devel@nongnu.org, Artyom Tarasenko <atar4qemu@gmail.com>

On 29/12/13 23:51, Olivier Danet wrote:

> On SparcStations, the HostID field in the NVRAM is equal to the
> last three bytes of the MAC address (which is also stored in the NVRAM).
>
> This constant is used as an identification/serial number on Solaris.
>
> signed-off-by : Olivier Danet <odanet@caramail.com>
> ---
> include/hw/nvram/openbios_firmware_abi.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/hw/nvram/openbios_firmware_abi.h
> b/include/hw/nvram/openbios_firmware_abi.h
> index 5e6e5d4..492c8d5 100644
> --- a/include/hw/nvram/openbios_firmware_abi.h
> +++ b/include/hw/nvram/openbios_firmware_abi.h
> @@ -62,6 +62,8 @@ Sun_init_header(struct Sun_nvram *header, const
> uint8_t *macaddr, int machine_id
> header->type = 1;
> header->machine_id = machine_id & 0xff;
> memcpy(&header->macaddr, macaddr, 6);
> + memcpy(&header->hostid , &macaddr[3],3);

I think there is some whitespace damage on this patch? At least I 
couldn't apply it as is :/  Also the lack of a space after the final 
comma on the line above looks suspicious too... have you tried running 
scripts/checkpatch.pl on the resulting diffs?

> +
> /* Calculate checksum */
> tmp = 0;
> tmpptr = (uint8_t *)header;

Apart from the whitespace issues, the basic patch looks fine though.


ATB,

Mark.