From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGU68-0000AV-Mo for qemu-devel@nongnu.org; Thu, 20 Feb 2014 08:55:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGU63-0005Et-MM for qemu-devel@nongnu.org; Thu, 20 Feb 2014 08:55:32 -0500 Message-ID: <5306094B.4010608@redhat.com> Date: Thu, 20 Feb 2014 14:55:23 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1392904246-15575-1-git-send-email-aik@ozlabs.ru> <1392904246-15575-2-git-send-email-aik@ozlabs.ru> In-Reply-To: <1392904246-15575-2-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 1/6] boot: extend get_boot_devices_list() to ignore suffixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Alexander Graf , Andreas Faerber Il 20/02/2014 14:50, Alexey Kardashevskiy ha scritto: > As suffixes do not make sense for sPAPR's device tree and > there is no way to filter them out on the BusState::get_fw_dev_path > level, let's add an ability for the external caller to specify > whether to apply suffixes or not. > > We could handle suffixes in SLOF (ignore for now) but this would require > serious rework in the node opening code in SLOF which has no obvious > benefit for the currently emulated sPAPR machine. For the record, the commit message is not entirely correct in presenting the situation. QEMU *does not care in any way* of benefits for the currently emulated sPAPR machine. The benefit would be to QEMU in having simpler code. You just got a wildcard because Forth is scary. :) Paolo > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v4: > * changed commit message about not having plans in SLOF rework as it is scary :)