From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40975)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WGU90-0001FL-Lg
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 08:58:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WGU8u-0005jc-Mt
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 08:58:30 -0500
Message-ID: <530609F9.1060105@redhat.com>
Date: Thu, 20 Feb 2014 14:58:17 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1392904246-15575-1-git-send-email-aik@ozlabs.ru>
	<1392904246-15575-4-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1392904246-15575-4-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of
	/machine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, Andreas Faerber <afaerber@suse.de>

Il 20/02/2014 14:50, Alexey Kardashevskiy ha scritto:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> This is a first step towards QOMifying /machine.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

The patch was originally mine, so I could get it in if Andreas wants me 
to handle patches 2-3.  But for anyone else it would be missing your 
S-o-b line.

Paolo

> ---
>  include/hw/boards.h | 1 +
>  vl.c                | 5 +++++
>  2 files changed, 6 insertions(+)
>
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index c2096e6..8640272 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -29,6 +29,7 @@ struct QEMUMachine {
>      const char *name;
>      const char *alias;
>      const char *desc;
> +    const char *class_name;
>      QEMUMachineInitFunc *init;
>      QEMUMachineResetFunc *reset;
>      QEMUMachineHotAddCPUFunc *hot_add_cpu;
> diff --git a/vl.c b/vl.c
> index 01ab7e4..b300721 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4034,6 +4034,11 @@ int main(int argc, char **argv, char **envp)
>          qtest_init(qtest_chrdev, qtest_log);
>      }
>
> +    if (machine->class_name) {
> +        Object *m = object_new(machine->class_name);
> +        object_property_add_child(object_get_root(), "machine", m, NULL);
> +    }
> +
>      machine_opts = qemu_get_machine_opts();
>      kernel_filename = qemu_opt_get(machine_opts, "kernel");
>      initrd_filename = qemu_opt_get(machine_opts, "initrd");
>