From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v5 1/6] boot: extend get_boot_devices_list() to ignore suffixes
Date: Thu, 20 Feb 2014 15:05:44 +0100 [thread overview]
Message-ID: <53060BB8.5010302@redhat.com> (raw)
In-Reply-To: <53060B40.9010903@ozlabs.ru>
Il 20/02/2014 15:03, Alexey Kardashevskiy ha scritto:
> On 02/21/2014 12:55 AM, Paolo Bonzini wrote:
>> Il 20/02/2014 14:50, Alexey Kardashevskiy ha scritto:
>>> As suffixes do not make sense for sPAPR's device tree and
>>> there is no way to filter them out on the BusState::get_fw_dev_path
>>> level, let's add an ability for the external caller to specify
>>> whether to apply suffixes or not.
>>>
>>> We could handle suffixes in SLOF (ignore for now) but this would require
>>> serious rework in the node opening code in SLOF which has no obvious
>>> benefit for the currently emulated sPAPR machine.
>>
>> For the record, the commit message is not entirely correct in presenting
>> the situation. QEMU *does not care in any way* of benefits for the
>> currently emulated sPAPR machine. The benefit would be to QEMU in having
>> simpler code.
>>
>> You just got a wildcard because Forth is scary. :)
>
> I know :) Should I remove that part and replace it with the "scary" one?
No, unless you have to respin for other reasons (I hope not).
Paolo
next prev parent reply other threads:[~2014-02-20 14:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 13:50 [Qemu-devel] [PATCH v5 0/6] spapr: bootindex support Alexey Kardashevskiy
2014-02-20 13:50 ` [Qemu-devel] [PATCH v5 1/6] boot: extend get_boot_devices_list() to ignore suffixes Alexey Kardashevskiy
2014-02-20 13:55 ` Paolo Bonzini
2014-02-20 14:03 ` Alexey Kardashevskiy
2014-02-20 14:05 ` Paolo Bonzini [this message]
2014-03-13 3:32 ` Alexey Kardashevskiy
2014-03-13 8:00 ` Paolo Bonzini
2014-02-20 13:50 ` [Qemu-devel] [PATCH v5 2/6] qdev: introduce FWPathProvider interface Alexey Kardashevskiy
2014-03-12 18:07 ` Andreas Färber
2014-03-12 18:15 ` Paolo Bonzini
2014-03-12 23:02 ` Alexey Kardashevskiy
2014-03-12 23:38 ` Andreas Färber
2014-03-13 1:03 ` Alexey Kardashevskiy
2014-03-13 3:40 ` Alexey Kardashevskiy
2014-02-20 13:50 ` [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine Alexey Kardashevskiy
2014-02-20 13:58 ` Paolo Bonzini
2014-02-27 10:34 ` Andreas Färber
2014-02-27 10:41 ` Paolo Bonzini
2014-02-27 14:39 ` Marcel Apfelbaum
2014-02-27 14:59 ` Paolo Bonzini
2014-02-27 15:04 ` Marcel Apfelbaum
2014-02-28 15:03 ` Alexey Kardashevskiy
2014-02-28 15:05 ` Paolo Bonzini
2014-02-28 15:08 ` Alexey Kardashevskiy
2014-02-28 15:57 ` Andreas Färber
2014-02-28 16:35 ` Paolo Bonzini
2014-03-03 10:04 ` Alexey Kardashevskiy
2014-02-21 3:04 ` Alexey Kardashevskiy
2014-02-21 10:30 ` Paolo Bonzini
2014-02-27 2:35 ` Alexey Kardashevskiy
2014-02-27 7:44 ` Markus Armbruster
2014-02-27 11:47 ` Alexey Kardashevskiy
2014-02-27 13:38 ` Markus Armbruster
2014-02-20 13:50 ` [Qemu-devel] [PATCH v5 4/6] spapr-llan: add to boot device list Alexey Kardashevskiy
2014-02-20 13:50 ` [Qemu-devel] [PATCH v5 5/6] spapr-vio: fix firmware names Alexey Kardashevskiy
2014-02-20 13:50 ` [Qemu-devel] [PATCH v5 6/6] spapr: define interface to fix device pathname Alexey Kardashevskiy
2014-02-20 13:58 ` [Qemu-devel] [PATCH v5 0/6] spapr: bootindex support Paolo Bonzini
2014-02-20 14:05 ` Alexey Kardashevskiy
2014-02-20 14:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53060BB8.5010302@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).