From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGVfC-0007DQ-DW for qemu-devel@nongnu.org; Thu, 20 Feb 2014 10:35:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGVf3-0005Br-T7 for qemu-devel@nongnu.org; Thu, 20 Feb 2014 10:35:50 -0500 Received: from mail-ee0-x22f.google.com ([2a00:1450:4013:c00::22f]:58190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGVf3-0005BW-LL for qemu-devel@nongnu.org; Thu, 20 Feb 2014 10:35:41 -0500 Received: by mail-ee0-f47.google.com with SMTP id d49so1039853eek.34 for ; Thu, 20 Feb 2014 07:35:40 -0800 (PST) Sender: Paolo Bonzini Message-ID: <530620C7.7060208@redhat.com> Date: Thu, 20 Feb 2014 16:35:35 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1392827321-10205-1-git-send-email-roland@kernel.org> <5304E4E4.10703@redhat.com> <5304F3D4.9060501@suse.de> <53052B92.7080305@redhat.com> In-Reply-To: <53052B92.7080305@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roland Dreier , =?ISO-8859-1?Q?Andreas_F=E4?= =?ISO-8859-1?Q?rber?= Cc: qemu-devel@nongnu.org Il 19/02/2014 23:09, Paolo Bonzini ha scritto: > Oversight, but it convinces me more that we should just match [_-] also > against the other in the pair. Must find time to write that patch... Looks like _ is more common than - for device properties: $ git grep DEFINE_PROP_.*\(\".*_.*\" | wc -l 132 $ git grep DEFINE_PROP_.*\(\".*-.*\" | wc -l 77 Paolo