Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h

["Andreas Färber" <afaerber@suse.de>]

Am 20.02.2014 16:35, schrieb Paolo Bonzini:
> Il 19/02/2014 23:09, Paolo Bonzini ha scritto:
>> Oversight, but it convinces me more that we should just match [_-] also
>> against the other in the pair.  Must find time to write that patch...
> 
> Looks like _ is more common than - for device properties:
> 
> $ git grep DEFINE_PROP_.*\(\".*_.*\" | wc -l
> 132
> $ git grep DEFINE_PROP_.*\(\".*-.*\" | wc -l
> 77

Not unexpected, it's the older; the - convention was introduced possibly
with QOM around start of 2012. Or at least there it's been enforced, and
by my understanding of QOM and QMP visibility it then applies to devices
as well.

Regarding QMP, I consider it smarter to do the _ -> - matching at
QemuOpts level than somewhere inside QOM.

For -cpu we have such compatibility code (although non-QemuOpts) in
target-i386/cpu.c, converting all underscores. Unfortunately that won't
work as long as there are underscores in old properties. Maybe you have
some cool patch idea?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg