From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Roland Dreier <roland@purestorage.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h
Date: Thu, 20 Feb 2014 17:10:56 +0100 [thread overview]
Message-ID: <53062910.3030009@redhat.com> (raw)
In-Reply-To: <5306270E.4020105@suse.de>
Il 20/02/2014 17:02, Andreas Färber ha scritto:
> Not unexpected, it's the older; the - convention was introduced possibly
> with QOM around start of 2012. Or at least there it's been enforced, and
> by my understanding of QOM and QMP visibility it then applies to devices
> as well.
>
> Regarding QMP, I consider it smarter to do the _ -> - matching at
> QemuOpts level than somewhere inside QOM.
That's fine, because device_add uses QemuOpts internally.
> For -cpu we have such compatibility code (although non-QemuOpts) in
> target-i386/cpu.c, converting all underscores. Unfortunately that won't
> work as long as there are underscores in old properties. Maybe you have
> some cool patch idea?
Well, no cool idea except "once conversion is done at the QemuOpts
level, do a full sweep of s/_/-/". This should be done before we'll be
able to create devices with object-add. I think as long as we have a
plan, consistency trumps design-by-committee convention.
Paolo
next prev parent reply other threads:[~2014-02-20 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 16:28 [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h Roland Dreier
2014-02-19 17:07 ` Paolo Bonzini
2014-02-19 18:11 ` Andreas Färber
2014-02-19 18:18 ` Roland Dreier
2014-02-19 22:09 ` Paolo Bonzini
2014-02-20 15:35 ` Paolo Bonzini
2014-02-20 16:02 ` Andreas Färber
2014-02-20 16:10 ` Paolo Bonzini [this message]
2014-02-20 17:54 ` Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2014-02-20 17:14 Roland Dreier
2014-02-20 17:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53062910.3030009@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).