From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGWKi-0003b7-3g for qemu-devel@nongnu.org; Thu, 20 Feb 2014 11:18:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGWKb-0002lV-Q2 for qemu-devel@nongnu.org; Thu, 20 Feb 2014 11:18:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGWKb-0002l1-Hl for qemu-devel@nongnu.org; Thu, 20 Feb 2014 11:18:37 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1KGIZ9X009848 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Feb 2014 11:18:36 -0500 Message-ID: <53062ADA.8000102@redhat.com> Date: Thu, 20 Feb 2014 09:18:34 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392908243-8835-1-git-send-email-kwolf@redhat.com> <1392908243-8835-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1392908243-8835-5-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SxkFkFAo4wUamjndVRn3cAGhF9rEdjkDd" Subject: Re: [Qemu-devel] [PATCH v2 4/6] qemu-img amend: Support multiple -o options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SxkFkFAo4wUamjndVRn3cAGhF9rEdjkDd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/20/2014 07:57 AM, Kevin Wolf wrote: > Instead of ignoring all option values but the last one, multiple -o > options now have the same meaning as having a single option with all > settings in the order of their respective -o options. >=20 > Signed-off-by: Kevin Wolf > --- > qemu-img.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) Same comment as in 2/6 about the surprise of a trailing comma empty option turning into a literal comma. Reviewed-by: Eric Blake >=20 > diff --git a/qemu-img.c b/qemu-img.c > index ba6e82d..d6dc7ec 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -2658,7 +2658,13 @@ static int img_amend(int argc, char **argv) > help(); > break; Noticed this in context - this break is dead code, since help() never returns. (And remind me again WHY help has to return with non-zero status, even when explicitly requested?) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SxkFkFAo4wUamjndVRn3cAGhF9rEdjkDd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTBiraAAoJEKeha0olJ0NqVlQIAJUccjwKHNyW2Dtu9tAiKBtn bG1nIvh2KiFjeV9YeIG+E1Gv2TQAy80Vja83VWosvpnhwrS68Hns/P54hnn9uJyV SfB4IwldsC66ZsLqokEm1gVOwjoyAO1/+C8MVmMZCvE7+mZO9eKVDV9jyQ4a86Ck j6coxXQzJ6Bj7Lrn7borwAbefg8ORMWgNvzgRZmOhteoVtO91KEqp1WGMkp7+BqH liOdRx4BeOrnAJPrFvhl6Bs9toLtQVCO0EgvGBGB72ViiwfwXLn2jeCG3YnMCHmy 6BMqEabyyfAJZLpXRoJgNS0TiqKXSM0W57SGmwwfxDjHzOcOljVgq/Lm/OUDsGU= =S/kg -----END PGP SIGNATURE----- --SxkFkFAo4wUamjndVRn3cAGhF9rEdjkDd--