From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGWQK-0005bW-0X for qemu-devel@nongnu.org; Thu, 20 Feb 2014 11:24:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGWQF-0004zN-4Y for qemu-devel@nongnu.org; Thu, 20 Feb 2014 11:24:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGWQE-0004xb-Ik for qemu-devel@nongnu.org; Thu, 20 Feb 2014 11:24:27 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1KGOPZV004534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Feb 2014 11:24:25 -0500 Message-ID: <53062C38.7050203@redhat.com> Date: Thu, 20 Feb 2014 09:24:24 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392908243-8835-1-git-send-email-kwolf@redhat.com> <1392908243-8835-3-git-send-email-kwolf@redhat.com> <530624A8.6090403@redhat.com> In-Reply-To: <530624A8.6090403@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iAlvljD3HLivPpiOd80lSht779Dbx64wP" Subject: Re: [Qemu-devel] [PATCH v2 2/6] qemu-img create: Support multiple -o options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iAlvljD3HLivPpiOd80lSht779Dbx64wP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/20/2014 08:52 AM, Eric Blake wrote: > Previously: >=20 > qemu-img create -f qcow2 -o backing_file=3D/dev/null, xyz 1M >=20 > creates xyz with a backing file of /dev/null and unspecified backing > format (and ignores the empty trailing option). > And maybe patch get_opt_value() to detect and reject empty > trailing options as well. Further evidence for my desire to improve get_opt_value() for consistency: we already reject empty leading options... $ qemu-img create -f qcow2 -o ,backing_file=3D/dev/null xyz 1MUnknown option '' qemu-img: xyz: Invalid options for file format 'qcow2'. =2E..although we happily ignore an empty option: $ qemu-img create -f qcow2 -o '' xyz 1M Formatting 'xyz', fmt=3Dqcow2 size=3D1048576 encryption=3Doff cluster_size=3D65536 lazy_refcounts=3Doff --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --iAlvljD3HLivPpiOd80lSht779Dbx64wP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTBiw4AAoJEKeha0olJ0NqCfkH/3leBRnxKWKlgQoKFI6LXL11 epIbyGcL+MDRt5kVpy9XmfCgKODndExU1Ucl+sGyife23P0pX0WzwpflQ1A8vvTV oaBzhCjBsfYNZiZ/qqYf9+0eXMi/GZz/q9hmOEAp9nmhFnXup7XmYfG1LBGSnVc9 7RpDsF+HiFqyhKjc/yhP2+rlXQvLHkZlcAtG0WQAh31l/Bcr+KrmOFL3SMmBcboL sz6CkUL9MgNZrXpHNxPgz3z1sbMJihhOAlP4VHb5fdot03zedBFNXTaCy2/3WMk5 PnK48M2C30QalTcYFNJnSYPovE5vO/CbdpuGPx9KDAA3GoGsPpMosuA2oIZ4S1Q= =arwl -----END PGP SIGNATURE----- --iAlvljD3HLivPpiOd80lSht779Dbx64wP--