From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGWxQ-0007oQ-M7 for qemu-devel@nongnu.org; Thu, 20 Feb 2014 11:58:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGWxL-00006J-Pw for qemu-devel@nongnu.org; Thu, 20 Feb 2014 11:58:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGWxL-000069-GS for qemu-devel@nongnu.org; Thu, 20 Feb 2014 11:58:39 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1KGwbHw021282 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Feb 2014 11:58:38 -0500 Message-ID: <5306343C.3040008@redhat.com> Date: Thu, 20 Feb 2014 09:58:36 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392908243-8835-1-git-send-email-kwolf@redhat.com> <1392908243-8835-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1392908243-8835-6-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BOE3To7tfwXxRPmakF3bNIkXGpf30CnNB" Subject: Re: [Qemu-devel] [PATCH v2 5/6] qemu-img: Allow -o help with incomplete argument list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BOE3To7tfwXxRPmakF3bNIkXGpf30CnNB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/20/2014 07:57 AM, Kevin Wolf wrote: > This patch allows using 'qemu-img $subcmd -o help' for the create, > convert and amend subcommands, without specifying the previously > required filename arguments. >=20 Oh cool! My complaint worked! > Note that it's still allowed and meaningful to specify a filename: An > invocation like 'qemu-img create -o help sheepdog:foo' will also displa= y > options that are provided by the Sheepdog driver. >=20 > Signed-off-by: Kevin Wolf > --- > qemu-img.c | 58 +++++++++++++++++++++++++++++++++++-------------------= ---- > 1 file changed, 35 insertions(+), 23 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BOE3To7tfwXxRPmakF3bNIkXGpf30CnNB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTBjQ8AAoJEKeha0olJ0NqcasH/3NGgktiH4FeIEeAcCg3aBEP sCP8XxI6ytoY3l7Cg5hc0h2Lao1f/ULyFhdPbVzF5oJjH0eRwhunuU+G4tBkmyRe KjnD+Uzo5oMJKUT3jsTvgklSU/qKVKSwVE1/EwqF/HXm4WFy8hn1MQxGwturWxdB G9WiVZvNRyyRHHbKms0IBLuNX/BEISenpr7HqmCMiF2aKv+r3tXx1ktBvOBvFONk Ds7NTQr8OvSDrmmSUbsslL8SPXcMsD0htz+29NKDfGb7l5O+Wg4T7PtXRkZgHvUc 7+QUP3oKl5W9uzbeBpGOpmlE5VFimDYpgpAMk8lqQuQ7ZYliBe/WszXzUk8tYtU= =v9Lk -----END PGP SIGNATURE----- --BOE3To7tfwXxRPmakF3bNIkXGpf30CnNB--