From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGXE3-0006Z7-1D for qemu-devel@nongnu.org; Thu, 20 Feb 2014 12:16:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGXDx-0006RX-1P for qemu-devel@nongnu.org; Thu, 20 Feb 2014 12:15:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGXDw-0006RR-Pj for qemu-devel@nongnu.org; Thu, 20 Feb 2014 12:15:48 -0500 Message-ID: <5306383F.6060109@redhat.com> Date: Thu, 20 Feb 2014 18:15:43 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roland Dreier Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org Il 20/02/2014 18:14, Roland Dreier ha scritto: >> > Looks like _ is more common than - for device properties: >> > >> > $ git grep DEFINE_PROP_.*\(\".*_.*\" | wc -l >> > 132 >> > $ git grep DEFINE_PROP_.*\(\".*-.*\" | wc -l >> > 77 > And more locally, "scsi-id" in scsi-bus.c is the only property in > hw/scsi with a '-'. scsi-disk.c already has "max_unmap_size" and > megasas.c has several '_' already. > > With that said I'm fine either way, and if you want to munge my patch > to use '-' that's perfectly OK with me. Or I'm happy to resubmit in > the other form. No, your patch is fine. We'll sort out what to do with underscores and dashes, looks like there is a plan... Thanks for your contribution to QEMU! Paolo