From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGXoO-0006hX-UY for qemu-devel@nongnu.org; Thu, 20 Feb 2014 12:53:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGXoK-00028S-2X for qemu-devel@nongnu.org; Thu, 20 Feb 2014 12:53:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGXoJ-00028L-PF for qemu-devel@nongnu.org; Thu, 20 Feb 2014 12:53:23 -0500 Message-ID: <5306410F.30709@redhat.com> Date: Thu, 20 Feb 2014 10:53:19 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392875695-15627-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1392875695-15627-11-git-send-email-xiawenc@linux.vnet.ibm.com> <87r46xvi5j.fsf@blackfin.pond.sub.org> In-Reply-To: <87r46xvi5j.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4UqQD562pHPLQN7J4qrFBcb1KfG7xlPgQ" Subject: Re: [Qemu-devel] [PATCH V7 10/11] qapi script: do not add "_" for every capitalized char in enum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Wenchao Xia Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4UqQD562pHPLQN7J4qrFBcb1KfG7xlPgQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/20/2014 09:54 AM, Markus Armbruster wrote: >> + # When c is upper and no "_" appears before, do more checks >> + if c.isupper() and (i > 0) and c_fun_str[i - 1] !=3D "_": >=20 > c_fun_str[i - 1]... what if i =3D=3D 0? How? We already had '(i > 0) and' prior to the use of i-1. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4UqQD562pHPLQN7J4qrFBcb1KfG7xlPgQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTBkEPAAoJEKeha0olJ0NqLj0H/2Yb35iBhw+RiLlD2g4KOF8o YXqRGJzOuu1OMpS7IbIfroG8Webr+7VzOftgmde20l+FMb0vfqRIaEHB9JFwmQxL lVPccep+sQHzgyHukkXECt5/h19sRId5RvOgSSmbiQumz1sbwUyyTIsUchsdoxsm 4ouY1iUbYtqMo1Dp+N6wkXJPJMXggeTBOnlz+NwLmZp/Ko2NP2TZMcbgXtva/V1Z QByKbAItHvfo5bEhnfPDMWAyM/wTL017arXsxpPxjiFYXMpT0uUhOjBGUdvVgOjo TQjApUrMJFG9tOGY6TJGzBYAqGY1TokHV8cqRsSfXa/xZp2Qfsxu8LI6jErdFME= =Hczx -----END PGP SIGNATURE----- --4UqQD562pHPLQN7J4qrFBcb1KfG7xlPgQ--