From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGarD-0002j2-6L for qemu-devel@nongnu.org; Thu, 20 Feb 2014 16:08:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGar7-0003Eo-8N for qemu-devel@nongnu.org; Thu, 20 Feb 2014 16:08:35 -0500 Received: from mail-qc0-x233.google.com ([2607:f8b0:400d:c01::233]:45085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGar7-0003Ed-3p for qemu-devel@nongnu.org; Thu, 20 Feb 2014 16:08:29 -0500 Received: by mail-qc0-f179.google.com with SMTP id e16so4161745qcx.24 for ; Thu, 20 Feb 2014 13:08:28 -0800 (PST) Sender: Richard Henderson Message-ID: <53066EC6.9080002@twiddle.net> Date: Thu, 20 Feb 2014 15:08:22 -0600 From: Richard Henderson MIME-Version: 1.0 References: <1392925373-14393-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1392925373-14393-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] tcg/i386: Fix build for systems without working cpuid.h (MacOSX, Win32) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org On 02/20/2014 01:42 PM, Peter Maydell wrote: > Win32 doesn't have a cpuid.h, and MacOSX may have one but without > the __cpuid() function we use, which means that commit 9d2eec20 > broke the build for those platforms. Fix this by tightening up > our configure cpuid.h check to test that the functions we need > are present, and adding some missing #ifdef guards in > tcg/i386/tcg-target.c. > > Signed-off-by: Peter Maydell > --- > Changes v1->v2: fix typo in commit message, add __cpuid_count() > to the configure test > > configure | 13 ++++++++++++- > tcg/i386/tcg-target.c | 4 +++- > 2 files changed, 15 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~