From: Brad Smith <brad@comstyle.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Patch Tracking <patches@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] tcg/i386: Fix build for systems without working cpuid.h (MacOSX, Win32)
Date: Thu, 20 Feb 2014 19:48:25 -0500 [thread overview]
Message-ID: <5306A259.7020104@comstyle.com> (raw)
In-Reply-To: <CAFEAcA8bVUwxq21QbQKA4J3h=oLb7QOOikcMjGkf0XwwQSmYhg@mail.gmail.com>
On 20/02/14 7:09 PM, Peter Maydell wrote:
> On 20 February 2014 23:55, Brad Smith <brad@comstyle.com> wrote:
>> On 20/02/14 12:50 PM, Peter Maydell wrote:
>>>
>>> Win32 doesn't have a cpuid.h, and MacOSX may have one but without
>>> the __cpuid() function we use, which means that commit 9d2eec20
>>> broke the build for those platforms. Fix this by tightening up
>>> our configure cpuid.h check to test that the functions we need
>>> are present, and adding some missing #ifdef guerds in
>>> tcg/i386/tcg-target.c.
>>
>>
>> The build will also fail if not using fairly new GCC
>
> Do you happen to know how new 'fairly new' is? My stock compile
> is with gcc 4.6.something, which isn't a spring chicken any more,
> and that worked OK.
>
> (We're going to fix this anyway, so it's just for my curiosity.)
Ok, it wasn't as new as I had thought. Actually taking a look at the
various releases __cpuid was added with GCC 4.3. __cpuid_count was
added with GCC 4.4.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
prev parent reply other threads:[~2014-02-21 0:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 17:50 [Qemu-devel] [PATCH] tcg/i386: Fix build for systems without working cpuid.h (MacOSX, Win32) Peter Maydell
2014-02-20 17:53 ` Peter Maydell
2014-02-20 19:22 ` Richard Henderson
2014-02-20 21:18 ` Stefan Weil
2014-02-20 22:18 ` Peter Maydell
2014-02-21 5:53 ` Stefan Weil
2014-02-21 16:32 ` Peter Maydell
2014-02-20 23:55 ` Brad Smith
2014-02-21 0:09 ` Peter Maydell
2014-02-21 0:48 ` Brad Smith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5306A259.7020104@comstyle.com \
--to=brad@comstyle.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).