From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGeI6-0006ZM-At for qemu-devel@nongnu.org; Thu, 20 Feb 2014 19:48:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGeI3-0004UF-2z for qemu-devel@nongnu.org; Thu, 20 Feb 2014 19:48:34 -0500 Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:22852 helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGeI2-0004UB-U5 for qemu-devel@nongnu.org; Thu, 20 Feb 2014 19:48:31 -0500 Message-ID: <5306A259.7020104@comstyle.com> Date: Thu, 20 Feb 2014 19:48:25 -0500 From: Brad Smith MIME-Version: 1.0 References: <1392918631-14234-1-git-send-email-peter.maydell@linaro.org> <530695F7.8080406@comstyle.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcg/i386: Fix build for systems without working cpuid.h (MacOSX, Win32) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Patch Tracking , QEMU Developers , Richard Henderson On 20/02/14 7:09 PM, Peter Maydell wrote: > On 20 February 2014 23:55, Brad Smith wrote: >> On 20/02/14 12:50 PM, Peter Maydell wrote: >>> >>> Win32 doesn't have a cpuid.h, and MacOSX may have one but without >>> the __cpuid() function we use, which means that commit 9d2eec20 >>> broke the build for those platforms. Fix this by tightening up >>> our configure cpuid.h check to test that the functions we need >>> are present, and adding some missing #ifdef guerds in >>> tcg/i386/tcg-target.c. >> >> >> The build will also fail if not using fairly new GCC > > Do you happen to know how new 'fairly new' is? My stock compile > is with gcc 4.6.something, which isn't a spring chicken any more, > and that worked OK. > > (We're going to fix this anyway, so it's just for my curiosity.) Ok, it wasn't as new as I had thought. Actually taking a look at the various releases __cpuid was added with GCC 4.3. __cpuid_count was added with GCC 4.4. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.