From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1WGgPz-0001yU-Tz
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 22:04:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1WGgPt-0002x5-P4
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 22:04:51 -0500
Received: from mail-pb0-f41.google.com ([209.85.160.41]:39349)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1WGgPt-0002wn-IS
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 22:04:45 -0500
Received: by mail-pb0-f41.google.com with SMTP id up15so2822053pbc.14
	for <qemu-devel@nongnu.org>; Thu, 20 Feb 2014 19:04:44 -0800 (PST)
Message-ID: <5306C241.1090403@ozlabs.ru>
Date: Fri, 21 Feb 2014 14:04:33 +1100
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <1392904246-15575-1-git-send-email-aik@ozlabs.ru>
	<1392904246-15575-4-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1392904246-15575-4-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of
	/machine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, Andreas Faerber <afaerber@suse.de>

On 02/21/2014 12:50 AM, Alexey Kardashevskiy wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> This is a first step towards QOMifying /machine.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

I got interesting conversation about "sob" in my team so here it is:

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Is that enough or I better repost the patch?
May be patchworks will pick it as it does for "RB" and other "by"'s.


> ---
>  include/hw/boards.h | 1 +
>  vl.c                | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index c2096e6..8640272 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -29,6 +29,7 @@ struct QEMUMachine {
>      const char *name;
>      const char *alias;
>      const char *desc;
> +    const char *class_name;
>      QEMUMachineInitFunc *init;
>      QEMUMachineResetFunc *reset;
>      QEMUMachineHotAddCPUFunc *hot_add_cpu;
> diff --git a/vl.c b/vl.c
> index 01ab7e4..b300721 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4034,6 +4034,11 @@ int main(int argc, char **argv, char **envp)
>          qtest_init(qtest_chrdev, qtest_log);
>      }
>  
> +    if (machine->class_name) {
> +        Object *m = object_new(machine->class_name);
> +        object_property_add_child(object_get_root(), "machine", m, NULL);
> +    }
> +
>      machine_opts = qemu_get_machine_opts();
>      kernel_filename = qemu_opt_get(machine_opts, "kernel");
>      initrd_filename = qemu_opt_get(machine_opts, "initrd");
> 


-- 
Alexey