From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>
Cc: gleb@kernel.org, thomas knych <thomaswk@google.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] KVM: Use return value for error print
Date: Fri, 21 Feb 2014 07:33:43 +0100 [thread overview]
Message-ID: <5306F347.6020806@redhat.com> (raw)
In-Reply-To: <1390832289-18701-1-git-send-email-agraf@suse.de>
Il 27/01/2014 15:18, Alexander Graf ha scritto:
> Commit 94ccff13 introduced a more verbose failure message and retry
> operations on KVM VM creation. However, it ended up using a variable
> for its failure message that hasn't been initialized yet.
>
> Fix it to use the value it meant to set.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> kvm-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index a3fb8de..3f78651 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1427,7 +1427,7 @@ int kvm_init(void)
> } while (ret == -EINTR);
>
> if (ret < 0) {
> - fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -s->vmfd,
> + fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret,
> strerror(-ret));
>
> #ifdef TARGET_S390X
>
Applied to uq/master, thanks.
Paolo
prev parent reply other threads:[~2014-02-21 6:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 14:18 [Qemu-devel] [PATCH] KVM: Use return value for error print Alexander Graf
2014-01-27 23:12 ` Tom Knych
2014-02-21 6:18 ` Michael Roth
2014-02-21 6:33 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5306F347.6020806@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=gleb@kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=thomaswk@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).