* Re: [Qemu-devel] [PATCH] KVM: Use return value for error print
2014-01-27 14:18 [Qemu-devel] [PATCH] KVM: Use return value for error print Alexander Graf
@ 2014-01-27 23:12 ` Tom Knych
2014-02-21 6:18 ` Michael Roth
2014-02-21 6:33 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Knych @ 2014-01-27 23:12 UTC (permalink / raw)
To: Alexander Graf
Cc: gleb, Paolo Bonzini, Marcelo Tosatti, QEMU Developers,
qemu-stable
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
+1
On Mon, Jan 27, 2014 at 6:18 AM, Alexander Graf <agraf@suse.de> wrote:
> Commit 94ccff13 introduced a more verbose failure message and retry
> operations on KVM VM creation. However, it ended up using a variable
> for its failure message that hasn't been initialized yet.
>
> Fix it to use the value it meant to set.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> kvm-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index a3fb8de..3f78651 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1427,7 +1427,7 @@ int kvm_init(void)
> } while (ret == -EINTR);
>
> if (ret < 0) {
> - fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -s->vmfd,
> + fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret,
> strerror(-ret));
>
> #ifdef TARGET_S390X
> --
> 1.8.1.4
>
>
[-- Attachment #2: Type: text/html, Size: 1420 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] KVM: Use return value for error print
2014-01-27 14:18 [Qemu-devel] [PATCH] KVM: Use return value for error print Alexander Graf
2014-01-27 23:12 ` Tom Knych
@ 2014-02-21 6:18 ` Michael Roth
2014-02-21 6:33 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Michael Roth @ 2014-02-21 6:18 UTC (permalink / raw)
To: Alexander Graf, QEMU Developers
Cc: gleb, Paolo Bonzini, Marcelo Tosatti, qemu-stable, thomas knych
Quoting Alexander Graf (2014-01-27 08:18:09)
> Commit 94ccff13 introduced a more verbose failure message and retry
> operations on KVM VM creation. However, it ended up using a variable
> for its failure message that hasn't been initialized yet.
>
> Fix it to use the value it meant to set.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
ping for 1.7.1
> ---
> kvm-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index a3fb8de..3f78651 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1427,7 +1427,7 @@ int kvm_init(void)
> } while (ret == -EINTR);
>
> if (ret < 0) {
> - fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -s->vmfd,
> + fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret,
> strerror(-ret));
>
> #ifdef TARGET_S390X
> --
> 1.8.1.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] KVM: Use return value for error print
2014-01-27 14:18 [Qemu-devel] [PATCH] KVM: Use return value for error print Alexander Graf
2014-01-27 23:12 ` Tom Knych
2014-02-21 6:18 ` Michael Roth
@ 2014-02-21 6:33 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2014-02-21 6:33 UTC (permalink / raw)
To: Alexander Graf, QEMU Developers
Cc: gleb, thomas knych, Marcelo Tosatti, qemu-stable
Il 27/01/2014 15:18, Alexander Graf ha scritto:
> Commit 94ccff13 introduced a more verbose failure message and retry
> operations on KVM VM creation. However, it ended up using a variable
> for its failure message that hasn't been initialized yet.
>
> Fix it to use the value it meant to set.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> kvm-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index a3fb8de..3f78651 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1427,7 +1427,7 @@ int kvm_init(void)
> } while (ret == -EINTR);
>
> if (ret < 0) {
> - fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -s->vmfd,
> + fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret,
> strerror(-ret));
>
> #ifdef TARGET_S390X
>
Applied to uq/master, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread