From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGv11-00016S-91 for qemu-devel@nongnu.org; Fri, 21 Feb 2014 13:40:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGv0w-0007sQ-0X for qemu-devel@nongnu.org; Fri, 21 Feb 2014 13:40:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGv0v-0007rv-N7 for qemu-devel@nongnu.org; Fri, 21 Feb 2014 13:39:57 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1LIdvqW010739 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Feb 2014 13:39:57 -0500 Message-ID: <53079D7C.6010500@redhat.com> Date: Fri, 21 Feb 2014 11:39:56 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393006301-22514-1-git-send-email-mreitz@redhat.com> <1393006301-22514-4-git-send-email-mreitz@redhat.com> In-Reply-To: <1393006301-22514-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WexUfAWKmut6sga5E7Ro5PHUiIIs3K9Pc" Subject: Re: [Qemu-devel] [PATCH 3/3] check-qdict: Adjust test for qdict_array_split() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WexUfAWKmut6sga5E7Ro5PHUiIIs3K9Pc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/21/2014 11:11 AM, Max Reitz wrote: > Test the new functionality of qdict_array_split(), that is, splitting > off single objects. >=20 > Signed-off-by: Max Reitz > --- > tests/check-qdict.c | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake However, I think it is incomplete - you didn't test the behavior when both %u and %u.sub appear in the same dict, to make sure the splitting stops at that point. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WexUfAWKmut6sga5E7Ro5PHUiIIs3K9Pc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTB518AAoJEKeha0olJ0NqQmgH/27PHP70vB95T0yNylFCdY0T rCPv5xdEbmZLs/V75pV6NRnComJXRlZpTqYNjPxHhzfeckqYIjuiefLvSkJsFY70 E0ycw0bO1bmt6XzrrZkfuJq5Tr2K2LlwNLfwbbWT+ByJKLOrQR2Xn+9TZKmcqePo ZFDjLyRA//f7ali/kYzX4eESSRlwE6GoHyTO3EPxPxt9XgZk3zAIYVo6xquUfZK1 dEtKNQES1r4OFgLiB2zfq9mQdlqrbsLZ4dQAjb9l4b6wENEz9vph+KZWvB3JA0VA 2iuQvdTboil2c2KJrrA5eLLoAYq6DvBfwpmr7MTryqdooci7Js5I48lLf9g7r3g= =/TUu -----END PGP SIGNATURE----- --WexUfAWKmut6sga5E7Ro5PHUiIIs3K9Pc--