From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WGvwM-0006on-C8
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 14:39:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WGvwF-0001XG-5e
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 14:39:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:27392)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WGvwE-0001XB-Tm
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 14:39:11 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1LJdAaK016742
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 21 Feb 2014 14:39:10 -0500
Message-ID: <5307ABFD.7030602@redhat.com>
Date: Fri, 21 Feb 2014 20:41:49 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1393006301-22514-1-git-send-email-mreitz@redhat.com>
	<1393006301-22514-4-git-send-email-mreitz@redhat.com>
	<53079D7C.6010500@redhat.com>
In-Reply-To: <53079D7C.6010500@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] check-qdict: Adjust test for
	qdict_array_split()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 21.02.2014 19:39, Eric Blake wrote:
> On 02/21/2014 11:11 AM, Max Reitz wrote:
>> Test the new functionality of qdict_array_split(), that is, splitting
>> off single objects.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   tests/check-qdict.c | 22 ++++++++++++++++------
>>   1 file changed, 16 insertions(+), 6 deletions(-)
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> However, I think it is incomplete - you didn't test the behavior when
> both %u and %u.sub appear in the same dict, to make sure the splitting
> stops at that point.

Yes, I'll add a test for that case, too.


Thanks for you review,

Max