From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGy65-0007uU-Nf for qemu-devel@nongnu.org; Fri, 21 Feb 2014 16:57:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGy61-00046K-8V for qemu-devel@nongnu.org; Fri, 21 Feb 2014 16:57:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGy60-00046G-W4 for qemu-devel@nongnu.org; Fri, 21 Feb 2014 16:57:25 -0500 Message-ID: <5307CBC1.50608@redhat.com> Date: Fri, 21 Feb 2014 14:57:21 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393017681-12794-1-git-send-email-benoit.canet@irqsave.net> <1393017681-12794-12-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1393017681-12794-12-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BbUXt5vktG86uObtD1x9r8b8aFCqpT7Ke" Subject: Re: [Qemu-devel] [PATCH V19 11/12] quorum: Add quorum_open() and quorum_close(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BbUXt5vktG86uObtD1x9r8b8aFCqpT7Ke Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/21/2014 02:21 PM, Beno=C3=AEt Canet wrote: > From: Beno=C3=AEt Canet >=20 > Example of command line: >=20 > -drive if=3Dvirtio,driver=3Dquorum,\ > children.0.file.filename=3D1.raw,\ > children.0.node-name=3D1.raw,\ > children.0.driver=3Draw,\ > children.1.file.filename=3D2.raw,\ > children.1.node-name=3D2.raw,\ > children.1.driver=3Draw,\ > children.2.file.filename=3D3.raw,\ > children.2.node-name=3D3.raw,\ > children.2.driver=3Draw,\ > vote-threshold=3D2 >=20 > +++ b/qapi-schema.json > @@ -4432,6 +4432,24 @@ > 'raw': 'BlockdevRef' } } > =20 > ## > +# @BlockdevOptionsQuorum > +# > +# Driver specific block device options for Quorum > +# > +# @blkverify: #optional true if the driver must print content mis= match > +# I might have mentioned it defaults to false. > +# @children: the children block device to use s/device/devices/ > +# > +# @vote_threshold: the vote limit under which a read will fail s/_/-/ to match the schema below > +# > +# Since: 2.0 > +## > +{ 'type': 'BlockdevOptionsQuorum', > + 'data': { '*blkverify': 'bool', > + 'children': [ 'BlockdevRef' ], > + 'vote-threshold': 'int' } } As this series is already queued, we may need a followup patch to fix these nits. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BbUXt5vktG86uObtD1x9r8b8aFCqpT7Ke Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTB8vBAAoJEKeha0olJ0NqJpAH/RufEL1Unsd+Wxn/9tM4iH8E 5ZrNsNOUPXxY4HmcZpcUzYEBlH++eHh7Xbn3AtZ/Oa/ITXIkSBcswGr0ZGfcTBAH L9SksNWTFaWneKDdS2+Fhj3tvOd9lb/c6ySVrx0BqnXYV+zABdUiJn0ojG0IT6RY kwNeqrL50Si3zd+jh79B5r9HH0FkC4P4dwofHa+9709qtULUS8z5h8vGfycHC585 m1NsYPzA+cW1suoXBvJUwEZZX++eieL05vPo5NsTclawYhehbp20YfE0LzxkRqpd Gl8gWGy5T6n3Y5fsQ/ZiPLZx0nNLIWVydHNMnfmniYkSdBqhCp6+zoZKdd/wr/k= =mvsv -----END PGP SIGNATURE----- --BbUXt5vktG86uObtD1x9r8b8aFCqpT7Ke--