From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGyI2-0007CU-59 for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:09:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGyHx-00081u-ML for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:09:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGyHx-00081d-EX for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:09:45 -0500 Message-ID: <5307CEA6.5050003@redhat.com> Date: Fri, 21 Feb 2014 15:09:42 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393017681-12794-1-git-send-email-benoit.canet@irqsave.net> <1393017681-12794-7-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1393017681-12794-7-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fbepVbaQNGrIQjlAiTeumI8IeTk49tn1g" Subject: Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fbepVbaQNGrIQjlAiTeumI8IeTk49tn1g Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/21/2014 02:21 PM, Beno=C3=AEt Canet wrote: > From: Beno=C3=AEt Canet >=20 > This patchset enables the core of the quorum mechanism. > The num_children reads are compared to get the majority version and if = this > version exists more than threshold times the guest won't see the error = at all. > +++ b/docs/qmp/qmp-events.txt > @@ -500,3 +500,39 @@ Example: > =20 > Note: If action is "reset", "shutdown", or "pause" the WATCHDOG event = is > followed respectively by the RESET, SHUTDOWN, or STOP events. > + > +QUORUM_FAILURE > +-------------- This should have been inserted in sorted order to match the rest of the file, rather than at the end. Can be rearranged in a followup patch, now that this series is queued. > + > +Emitted by the Quorum block driver if it fails to establish a quorum. > + > +Data: > + > +- "reference": device name if defined else node name. > +- "sector-num": Number of the first sector of the failed read operat= ion. I'm assuming sector-num is relative to the guest's view of the data? > + > +QUORUM_REPORT_BAD > +----------------- > + > +Emitted to report a corruption of a Quorum file. > + > +Data: > + > +- "ret": The IO return code. What values is this likely to contain? Is it a finite set, in which case it would be nice to have a QAPI enum that describes the set of return codes, rather than a raw number? I'd like to make sure we are happy with the wire format of this QMP event before it gets baked into 2.0. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fbepVbaQNGrIQjlAiTeumI8IeTk49tn1g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTB86mAAoJEKeha0olJ0Nq4JIH/2G210ZIKVvclINijl40rqmv 36TflzllH4kUUBPGy0sznrg1rT8Q4iHPwxprh7NT/wt6mMS3Td0PPn9sXSHAEDMc nVMyaPZamtgZBFqrPUxy7o1v0X6qSZYWmAeKRRR2fovRxw9LDtjS1geMJQVlUT0C ZDTxcaU1XbXAfZZXMu3sH0VzRzHtquWf+n7r9Xh6xbg55NAejAo44dKK16zC4Nfc aouYPJ463mu/RfQtmjKoEUAqtQk7HRVVQRt/zcIh+UOO+vMIq/KRCONbZEFfB/T/ I5nqGPREQZMqdaYKRdm4e2ja0dcrzHkSAE6NkPNjn/u2BbNE7m2VBwctLqzHbYU= =170D -----END PGP SIGNATURE----- --fbepVbaQNGrIQjlAiTeumI8IeTk49tn1g--